-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ign to gz] Factory::New accept ignition with warning #281
Conversation
Signed-off-by: Louise Poubel <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provisionally approving if the comment I left earlier can be disregarded :o
Codecov Report
@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 85.59% 84.62% -0.98%
==========================================
Files 10 10
Lines 972 995 +23
==========================================
+ Hits 832 842 +10
- Misses 140 153 +13
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Co-authored-by: methylDragon <[email protected]>
ignition
togz
gazebo-tooling/release-tools#711Summary
Accept
ignition
messages onFactory::New
, print warning and returngz
equivalent.Test it
Try sending an
ignition
message, see that it's sent, and a warning is printed.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸