-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Resize Images #416
Open
Shoaib-Qadeer
wants to merge
79
commits into
next
Choose a base branch
from
master
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Auto Resize Images #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add link to the live store * fix: update callback domain for Auth0 * feat: store redesign (#201) TODO: - [x] ~~refactor `ProductImagesBrowser` (for fixing transitions)~~ - [ ] filtering for `ProductListing` (by swag codes) () - [ ] internal Ads functionality - [x] ~~screens transitions/switching on mobile (some fixes/improvements)~~ - [ ] a couple updates in content - [x] ~~a list of small fixes and improvements in styles~~ Till the moment I fix the bugs in mobile switching/transitions I suggest testing the store on desktop, instead you will be pointing me strange behaviors I am aware of. * feat: update used swag code badge style (#212) * feat: style used badges, modify messaging, update badge theming * camelcase swag code badge title * fix: revert static test * feat: level 2 incentive (#213) Where a contributor has earned level 1, but not yet level 2, show a progress bar and messaging toward earning level 2. <img width="420" alt="screen shot 2019-01-06 at 11 52 30 am" src="https://user-images.githubusercontent.com/3461087/50739721-b0828600-11a9-11e9-8b0c-98a6c01e3565.png"> closes #207 * feat: add Google Analytics (#216) * chore: use official Shopify plugin (#217) - update to the Gatsby-maintained Shopify plugin (see gatsbyjs/gatsby#10955) - update the Shopify Buy SDK * fix: keep item quantity in sync (#218) - adding more of the same item to the cart updates its quantity input - add a basic “loading” animation while quantities update - convert the `CartListItem` component to use Hooks * feat: use custom domain for login closes #19 * fix: improve cart button accessibility (#220) * fix: add button label to shopping cart icon * fix: reorder components to announce shopping cart earlier
The plane wifi isn’t good enough to deploy to AWS, so we can’t update the custom domain until I land.
For now, let’s use @riencoertjens’s photo of Dora because it’s painfully cute. For more Dora, go follow https://www.instagram.com/doraforscale/ close #143
Products were renamed, including slugs, so this makes sure that no dead links happen.
- use product info and image for SEO tags on product pages - fix lorem ipsum text in captions closes #222
### 1 Addition to https://github.com/gatsbyjs/store.gatsbyjs.org/pull/226/files ![screenshot from 2019-01-11 10-23-06](https://user-images.githubusercontent.com/32480082/51027305-c371cd80-1590-11e9-9e9b-0139100e1a8e.png) ### 2 Fix '0' flickering during page loading ![screenshot from 2019-01-11 10-44-17](https://user-images.githubusercontent.com/32480082/51027304-c371cd80-1590-11e9-93a4-34fe5f421a1e.png)
Update conditional code to work with the new string of swag code level 2
Position `Footer` to the bottom of the container, so even when the main content is replaced/hidden by `offline` plugin during page loading the footer does not appear on the top of the page. ![screenshot from 2019-01-11 10-44-17](https://user-images.githubusercontent.com/32480082/51027769-008a8f80-1592-11e9-8051-f8628a334b26.png)
- Safari apparently requires trailing slashes or it dumps all hashes. So... we added a trailing slash. closes #106
No functionality changes; this just removes all unused code and simplifies a couple implicit returns in functional components.
The last one addition to #231
After changes: ![opensidebar-corrected](https://user-images.githubusercontent.com/9110567/52177427-85aa4280-27e6-11e9-95ff-80cc8c78c798.PNG) closes #248
I found an issue with gatsby-image on the store site, I created this PR gatsbyjs/gatsby#11303, so the issue has been fixed in the latest version. close #211
* Fix link to search for open issues on GitHub * Fix search for open issue link
According to my understanding the script `format`: `prettier --write 'src/**/*.js'` doesn't need the apices. The old syntax generated the following error: ``` > [email protected] format C:\Users\[USER]\[PATH]\store.gatsbyjs.org > prettier --write 'src/**/*.js' [error] No matching files. Patterns tried: 'src/**/*.js' !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/** npm ERR! code ELIFECYCLE npm ERR! errno 2 npm ERR! [email protected] format: `prettier --write 'src/**/*.js'` npm ERR! Exit status 2 npm ERR! npm ERR! Failed at the [email protected] format script. npm ERR! This is probably not a problem with npm. There is likely additional logging output above. npm ERR! A complete log of this run can be found in: npm ERR! C:\Users\[USER]\AppData\Roaming\npm-cache\_logs\2019-02-14T20_06_48_090Z-debug.log ```
removed duplicate selector `::-webkit-progress-value`
* add ability to copy the code with a button * revert lock.file change * remove overflow: hidden from div containing code badge and copy button to not clip the box-shadow effect on button
* Adding link to faqs * Tweak wording, structure Co-authored-by: Florian Kissling <[email protected]>
Change the label for open issues from 'status: help wanted' to 'help wanted'
…316) * Adding message for international orders about taxes * Move full point/stop punctuation outside of href Co-authored-by: Florian Kissling <[email protected]>
…ge) when navigating from size chart (#300)
This is an attempt to override GitHub always suggesting jlengstorf as a reviewer for PRs in this repo.
* fix: change support name from Jason to Marcy Sutton * Update src/components/ContributorArea/ContentForNotContributor.js Co-Authored-By: Mike Allanson <[email protected]> * Update src/components/Dashboard/Contributions.js Co-Authored-By: Mike Allanson <[email protected]> Co-authored-by: Mike Allanson <[email protected]>
* Use experimental shopify plugin * Version bump * Another version bump for performance * Plugin options (we need some read-only keys) * The store URL is certainly no secret * Version bump 1.5.0 * Version bump 1.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should auto-resize and adjust iamge