-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: open issues looking at wrong label #313
Conversation
Change the label for open issues from 'status: help wanted' to 'help wanted'
@@ -4,7 +4,7 @@ import styled from '@emotion/styled'; | |||
import { Query } from 'react-apollo'; | |||
import { GoMarkGithub } from 'react-icons/go'; | |||
|
|||
import { Subheading, Text } from './AreaTypography'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Text
was no longer in use so removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -63,7 +63,7 @@ const OpenIssues = () => ( | |||
<OpenIssuesList issues={issues} /> | |||
<Button | |||
inverse | |||
href="https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22help%20wanted%22+is%3Aopen&s=updated&type=Issues" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to use the GITHUB_LABEL
constant instead of hard coding the value.
Thoughts from @LekoArts or @sidharthachatterjee |
@@ -63,7 +63,7 @@ const OpenIssues = () => ( | |||
<OpenIssuesList issues={issues} /> | |||
<Button | |||
inverse | |||
href="https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22help%20wanted%22+is%3Aopen&s=updated&type=Issues" | |||
href={`https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22${GITHUB_LABEL}%22+is%3Aopen&s=updated&type=Issues`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we encodeURIComponent(GITHUB_LABEL)
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Just for the sake of completeness, this works w/o doing so)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed we're not encoding anything in
href={`https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22${GITHUB_LABEL}%22+is%3Aopen&s=updated&type=Issues`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hey @shawncarr, thanks so much for fixing this! 🤗 🙏
I left a minor comment, but AFAICS this is ready to merge!
Holy buckets, @shawncarr — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Issue:
Even though there is many issues marked as
help wanted
, zero are showing up for a user.Solution:
Change the label for open issues from
status: help wanted
tohelp wanted
so that issues are returned.