Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open issues looking at wrong label #313

Merged
merged 1 commit into from
Jan 6, 2020
Merged

Conversation

shawncarr
Copy link
Contributor

Issue:

Screen Shot 2019-11-21 at 5 03 32 PM

Even though there is many issues marked as help wanted, zero are showing up for a user.

Solution:

Change the label for open issues from status: help wanted to help wanted so that issues are returned.

Change the label for open issues from 'status: help wanted' to 'help wanted'
@@ -4,7 +4,7 @@ import styled from '@emotion/styled';
import { Query } from 'react-apollo';
import { GoMarkGithub } from 'react-icons/go';

import { Subheading, Text } from './AreaTypography';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Text was no longer in use so removed it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -63,7 +63,7 @@ const OpenIssues = () => (
<OpenIssuesList issues={issues} />
<Button
inverse
href="https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22help%20wanted%22+is%3Aopen&s=updated&type=Issues"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to use the GITHUB_LABEL constant instead of hard coding the value.

@shawncarr
Copy link
Contributor Author

Thoughts from @LekoArts or @sidharthachatterjee

@@ -63,7 +63,7 @@ const OpenIssues = () => (
<OpenIssuesList issues={issues} />
<Button
inverse
href="https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22help%20wanted%22+is%3Aopen&s=updated&type=Issues"
href={`https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22${GITHUB_LABEL}%22+is%3Aopen&s=updated&type=Issues`}
Copy link
Contributor

@fk fk Jan 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we encodeURIComponent(GITHUB_LABEL)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Just for the sake of completeness, this works w/o doing so)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed we're not encoding anything in

href={`https://github.com/search?o=desc&q=org%3Agatsbyjs+type%3Aissue+label%3A%22${GITHUB_LABEL}%22+is%3Aopen&s=updated&type=Issues`}
— and since this works fine w/o doing so, let's :shipit:!

Copy link
Contributor

@fk fk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hey @shawncarr, thanks so much for fixing this! 🤗 🙏
I left a minor comment, but AFAICS this is ready to merge!

@fk fk merged commit 583a20c into gatsbyjs:master Jan 6, 2020
@gatsbot
Copy link

gatsbot bot commented Jan 6, 2020

Holy buckets, @shawncarr — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants