Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: add action, verbiage for colors, and handle missing images #339

Merged
merged 2 commits into from
Sep 10, 2020

Conversation

gillkyle
Copy link
Contributor

Description

These changes do the following:

  • adds a GitHub action to rebuild the site nightly on Gatsby Cloud (we used to have some Zapier thingy hooked into Netlify, but I can't figure out how to get into Zapier and we don't build on Netlify anymore anyway)

  • handles missing images better so things don't blow up when a product gets published without one

  • tweaks verbiage around variants to say Size/Color for new products that have color variations instead of just sizes

@gillkyle gillkyle requested a review from a team as a code owner September 10, 2020 21:21
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 10, 2020

Gatsby Cloud Build Report

store.gatsbyjs.org

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 🔶 89
Accessibility 💚 100
Best Practices 💚 93
SEO 🔶 77

🔗 View full report

@gillkyle gillkyle merged commit 543204a into master Sep 10, 2020
@LekoArts LekoArts deleted the nightly-builds-and-tweaks branch September 16, 2020 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant