Fix cart button accessibility #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlengstorf
added a commit
that referenced
this pull request
Jan 11, 2019
* chore: add link to the live store * fix: update callback domain for Auth0 * feat: store redesign (#201) TODO: - [x] ~~refactor `ProductImagesBrowser` (for fixing transitions)~~ - [ ] filtering for `ProductListing` (by swag codes) () - [ ] internal Ads functionality - [x] ~~screens transitions/switching on mobile (some fixes/improvements)~~ - [ ] a couple updates in content - [x] ~~a list of small fixes and improvements in styles~~ Till the moment I fix the bugs in mobile switching/transitions I suggest testing the store on desktop, instead you will be pointing me strange behaviors I am aware of. * feat: update used swag code badge style (#212) * feat: style used badges, modify messaging, update badge theming * camelcase swag code badge title * fix: revert static test * feat: level 2 incentive (#213) Where a contributor has earned level 1, but not yet level 2, show a progress bar and messaging toward earning level 2. <img width="420" alt="screen shot 2019-01-06 at 11 52 30 am" src="https://user-images.githubusercontent.com/3461087/50739721-b0828600-11a9-11e9-8b0c-98a6c01e3565.png"> closes #207 * feat: add Google Analytics (#216) * chore: use official Shopify plugin (#217) - update to the Gatsby-maintained Shopify plugin (see gatsbyjs/gatsby#10955) - update the Shopify Buy SDK * fix: keep item quantity in sync (#218) - adding more of the same item to the cart updates its quantity input - add a basic “loading” animation while quantities update - convert the `CartListItem` component to use Hooks * feat: use custom domain for login closes #19 * fix: improve cart button accessibility (#220) * fix: add button label to shopping cart icon * fix: reorder components to announce shopping cart earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jlengstorf found it.