-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: a11y links do not have discernible names #319
fix: a11y links do not have discernible names #319
Conversation
hey, @abhishekakade — I'm no longer with Gatsby, so I don't manage this repo anymore thanks for submitting this, though! seems like a great addition @gatsbyjs/core might be worth changing the code owners for this repo so it stops suggesting me as a reviewer? |
@jlengstorf, oh, I'm sorry, I didn't know that. And thanks! I'll wait for the team to review it. |
@jlengstorf, I've opened #320 to try and prevent you from getting marked as a reviewer on PRs here. @abhishekakade thank you! This looks like an improvement to me. However, I wonder if the description should be something like this?
So that it describes the content of the target page. cc @madalynrose in case you have thoughts on this? |
Yes, it does seem to describe the content in a better way. @m-allanson, @madalynrose, let me know if I can go ahead with this change or suggest improvements if any. Thank you! |
@m-allanson I believe having it described the title of the targeted page there would be a good change. |
Any update on this? @m-allanson |
Assigning to @madalynrose who's like the perfect one to review this, anyways :D |
Oh goodness @abhishekakade I'm so sorry I haven't gotten to this! Thank you so much for taking the time to improve accessibility in our store! This looks great! |
@madalynrose, thank you! |
Fixes product links accessibility issues in accessibility audits (links do not have a discernible name).