Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a11y links do not have discernible names #319

Merged
merged 1 commit into from
Feb 20, 2020
Merged

fix: a11y links do not have discernible names #319

merged 1 commit into from
Feb 20, 2020

Conversation

abhishekakade
Copy link
Contributor

Fixes product links accessibility issues in accessibility audits (links do not have a discernible name).

@jlengstorf
Copy link
Contributor

hey, @abhishekakade — I'm no longer with Gatsby, so I don't manage this repo anymore

thanks for submitting this, though! seems like a great addition

@gatsbyjs/core might be worth changing the code owners for this repo so it stops suggesting me as a reviewer?

@jlengstorf jlengstorf removed their request for review January 14, 2020 19:51
@abhishekakade
Copy link
Contributor Author

@jlengstorf, oh, I'm sorry, I didn't know that. And thanks! I'll wait for the team to review it.

@m-allanson
Copy link
Contributor

@jlengstorf, I've opened #320 to try and prevent you from getting marked as a reviewer on PRs here.

@abhishekakade thank you! This looks like an improvement to me. However, I wonder if the description should be something like this?

{`Product listing for ${title}`}

So that it describes the content of the target page. cc @madalynrose in case you have thoughts on this?

@abhishekakade
Copy link
Contributor Author

{Product listing for ${title}}

Yes, it does seem to describe the content in a better way. @m-allanson, @madalynrose, let me know if I can go ahead with this change or suggest improvements if any. Thank you!

@Developerayo
Copy link
Contributor

@jlengstorf, I've opened #320 to try and prevent you from getting marked as a reviewer on PRs here.

@abhishekakade thank you! This looks like an improvement to me. However, I wonder if the description should be something like this?

{`Product listing for ${title}`}

So that it describes the content of the target page. cc @madalynrose in case you have thoughts on this?

@m-allanson I believe having it described the title of the targeted page there would be a good change.

@Developerayo Developerayo added the good first issue Good for newcomers label Jan 18, 2020
@abhishekakade
Copy link
Contributor Author

Any update on this? @m-allanson

@pvdz
Copy link

pvdz commented Feb 11, 2020

Assigning to @madalynrose who's like the perfect one to review this, anyways :D

@pvdz pvdz removed the request for review from m-allanson February 11, 2020 10:54
@pvdz pvdz requested a review from madalynrose February 11, 2020 10:54
@madalynrose
Copy link

Oh goodness @abhishekakade I'm so sorry I haven't gotten to this!

Thank you so much for taking the time to improve accessibility in our store! This looks great!

@madalynrose madalynrose merged commit e792de9 into gatsbyjs:master Feb 20, 2020
@abhishekakade
Copy link
Contributor Author

@madalynrose, thank you!

@abhishekakade abhishekakade deleted the fix-links-accessibility branch February 27, 2020 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants