Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Shopify source plugin #378

Merged

Conversation

ax-vasquez
Copy link
Contributor

@ax-vasquez ax-vasquez commented Mar 25, 2021

Update swag store to use the new gatsby-source-shopify (formerly-"experimental") plugin; Also update gatsby to v3

https://app.clubhouse.io/gatsbyjs/story/26529/upgrade-swag-gatsbyjs-org-to-gatsby-source-shopify-experimental

@ax-vasquez ax-vasquez force-pushed the armandovasquez/ch26529/updateSwagStoreShopifyPlugin branch from 6f4eab4 to 827d4fc Compare March 29, 2021 20:39
@ax-vasquez ax-vasquez marked this pull request as ready for review March 29, 2021 20:41
@ax-vasquez ax-vasquez requested a review from a team as a code owner March 29, 2021 20:41
ascorbic
ascorbic previously approved these changes Mar 30, 2021
@ax-vasquez ax-vasquez force-pushed the armandovasquez/ch26529/updateSwagStoreShopifyPlugin branch from 827d4fc to 9731b6c Compare March 30, 2021 18:45
@gatsby-cloud
Copy link

gatsby-cloud bot commented Mar 30, 2021

Gatsby Cloud Build Report

store.gatsbyjs.org

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 1m

Performance

Lighthouse report

Metric Score
Performance 🔶 59
Accessibility 💚 93
Best Practices 🔶 87
SEO 🔶 77

🔗 View full report

@ax-vasquez
Copy link
Contributor Author

ax-vasquez commented Mar 30, 2021

Squashing and merging this since we got the approval 👍 - only the initial cloud build failed, but was fixed by adding a new env var. Here is a link to the successful build details:

@ax-vasquez ax-vasquez merged commit abe3449 into master Mar 30, 2021
@ax-vasquez ax-vasquez deleted the armandovasquez/ch26529/updateSwagStoreShopifyPlugin branch March 30, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants