Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: npm run format #252

Merged
merged 1 commit into from
Feb 14, 2019
Merged

Fix: npm run format #252

merged 1 commit into from
Feb 14, 2019

Conversation

NeverMendel
Copy link
Contributor

@NeverMendel NeverMendel commented Feb 14, 2019

According to my understanding the script format: prettier --write 'src/**/*.js' doesn't need the apices.

The old syntax generated the following error:

> [email protected] format C:\Users\[USER]\[PATH]\store.gatsbyjs.org
> prettier --write 'src/**/*.js'

[error] No matching files. Patterns tried: 'src/**/*.js' !**/node_modules/** !./node_modules/** !**/.{git,svn,hg}/** !./.{git,svn,hg}/**
npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR! [email protected] format: `prettier --write 'src/**/*.js'`
npm ERR! Exit status 2
npm ERR! 
npm ERR! Failed at the [email protected] format script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\[USER]\AppData\Roaming\npm-cache\_logs\2019-02-14T20_06_48_090Z-debug.log

Copy link
Contributor

@jlengstorf jlengstorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, interesting. Looks like it works with or without on Mac, but not on Windows. Thanks for this!

@jlengstorf jlengstorf merged commit ce213c3 into gatsbyjs:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants