Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Auto button inside Chart style should read "Color: Auto" #32632

Closed
wants to merge 28 commits into from

Conversation

PhilippBaranovskiy
Copy link
Contributor

Fix: #25508

Summary

Added aria-label attribute for Color: Auto.
Since the original code is without internationalization, I left it so as well.

PhilippBaranovskiy and others added 28 commits March 6, 2019 07:01
* Fix some strings after translator feedback

* Fix jest tests

* Fix typo

* Fix Mocha tests

* Fix more mocha tests
* Adding legend controls

* Adding url support and finishing feature

* Moving config to right side; setting min/max to data boundries when deactivating auto

* Removing legend from max and min labels

* removing uneseccary unshift(0)

* Change autobounds behavior
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
* [ftr] flatten GenericProviderTypes to fix "log" types

* [ftr/remote] typscript-ify

* remove webdriver types, since they're version 3 and we're using version 4

* simplify initWebDriver() function

* keep jest tests in the functional tests as js, mixing jest and mocha types doesn't work
* Reenabling token auth provider test

* Re-enabling saml test

* Adding a SAML test to ensure we can't reuse refresh token after 60 seconds

* Adding token auth provider re-use refresh token after 60 seconds test

* Removing the reusuing refresh tokens after timeout
* [ML] Fix chart tooltip positioning for new K7 navigation

* [ML] Move numeric offset numbers into variables
Chatted with @markov00 and he suggests that we can disable the `dashboardExpect.panelCount()` assertions for now to avoid triggering elastic#28818. I'll work with @dmlemeshko and @markov00 to get a PR up that is heavily testing this suite and try nailing down what is causing this rendering disparity.
* Add `await` to common router request handler

* Remove once() from common license checker and call with request factories
Localize Maps-app UX with Kibana's i18n framework.
This is an internal refactor:
- move tooltip management out of layers, and to the mapbox-component
- use global handler iso of multiple handlers on individual layers (this did remove the cursor-pointer change, since we no longer are explicitly handling on-enter/leave events).
- put tooltip state in store

Fixes bugs:
- when layer is removed, any corresponding tooltip should be removed as well
- when layer is made invisible, any corresponding tooltip should be removed as well
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.