-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CCR] Fix form bug + add missing i18n #32544
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebelga
added
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Feature:Rollups
labels
Mar 6, 2019
Pinging @elastic/es-ui |
💚 Build Succeeded |
bmcconaghy
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM
cjcenizal
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! Code LGTM, didn't test locally.
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Mar 6, 2019
* [Rollup] Fix month value in form select * [Rollup] Add missing i18n for field types
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Mar 6, 2019
* [Rollup] Fix month value in form select * [Rollup] Add missing i18n for field types
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Mar 6, 2019
* [Rollup] Fix month value in form select * [Rollup] Add missing i18n for field types
sebelga
added a commit
that referenced
this pull request
Mar 6, 2019
sebelga
added a commit
that referenced
this pull request
Mar 6, 2019
sebelga
added a commit
that referenced
this pull request
Mar 6, 2019
PhilippBaranovskiy
pushed a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
* [Rollup] Fix month value in form select * [Rollup] Add missing i18n for field types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Feature:Rollups
Team:Kibana Management
Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
v6.7.1
v7.0.1
v7.2.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug in the rollup job creation month selector.
It also adds the missing translations for the field types in Rollup (the commit message is wrong for this fix).