Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] Fix form bug + add missing i18n #32544

Merged
merged 2 commits into from
Mar 6, 2019

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Mar 6, 2019

This PR fixes a small bug in the rollup job creation month selector.

It also adds the missing translations for the field types in Rollup (the commit message is wrong for this fix).

@sebelga sebelga requested review from jen-huang and cjcenizal March 6, 2019 10:54
@sebelga sebelga requested a review from bmcconaghy March 6, 2019 10:56
@sebelga sebelga added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Rollups labels Mar 6, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@bmcconaghy bmcconaghy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Code LGTM, didn't test locally.

@sebelga sebelga merged commit 9c37b69 into elastic:master Mar 6, 2019
@sebelga sebelga deleted the fix/rollup-month-select branch March 6, 2019 14:35
@sebelga sebelga added the v7.0.1 label Mar 6, 2019
sebelga added a commit to sebelga/kibana that referenced this pull request Mar 6, 2019
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
sebelga added a commit to sebelga/kibana that referenced this pull request Mar 6, 2019
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
sebelga added a commit to sebelga/kibana that referenced this pull request Mar 6, 2019
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
sebelga added a commit that referenced this pull request Mar 6, 2019
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
sebelga added a commit that referenced this pull request Mar 6, 2019
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
sebelga added a commit that referenced this pull request Mar 6, 2019
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
PhilippBaranovskiy pushed a commit to PhilippBaranovskiy/kibana that referenced this pull request Mar 7, 2019
* [Rollup] Fix month value in form select

* [Rollup] Add missing i18n for field types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Rollups Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v6.7.1 v7.0.1 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants