Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing pipeline_data_loader #32478

Merged
merged 4 commits into from
Mar 6, 2019
Merged

fixing pipeline_data_loader #32478

merged 4 commits into from
Mar 6, 2019

Conversation

ppisljar
Copy link
Member

@ppisljar ppisljar commented Mar 5, 2019

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@ppisljar ppisljar requested a review from lukeelmers March 5, 2019 12:49
@elasticmachine
Copy link
Contributor

💔 Build Failed

lukeelmers
lukeelmers approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@lukeelmers lukeelmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested Chrome OSX.

Should be good to merge once build is green (and once the __ENABLE_PIPELINE_DATA_LOADER__ toggle is set back to false)

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@ppisljar ppisljar merged commit 54e4982 into elastic:master Mar 6, 2019
@ppisljar ppisljar mentioned this pull request Mar 6, 2019
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 6, 2019
@ppisljar
fixing pipeline_data_loader (elastic#32478)
9f9c3ad
@ppisljar ppisljar mentioned this pull request Mar 6, 2019
Merged
ppisljar added a commit to ppisljar/kibana that referenced this pull request Mar 6, 2019
@ppisljar
fixing pipeline_data_loader (elastic#32478)
20c34d5
PhilippBaranovskiy pushed a commit to PhilippBaranovskiy/kibana that referenced this pull request Mar 7, 2019
@ppisljar @PhilippBaranovskiy
fixing pipeline_data_loader (elastic#32478)
3f030d8
ppisljar added a commit that referenced this pull request Mar 8, 2019
@ppisljar
fixing pipeline_data_loader (#32478) (#32545)
0e03c36
ppisljar added a commit that referenced this pull request Mar 8, 2019
@ppisljar
fixing pipeline_data_loader (#32478) (#32546)
69fc0d8
@ppisljar ppisljar added the chore label Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

Assignees
No one assigned
Labels
chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ppisljar @elasticmachine @lukeelmers