Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard/ftr] remove _-prefix from file names #32585

Merged
merged 1 commit into from
Mar 6, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Mar 6, 2019

I'm going to try and clean up some of the redundant operations in the dashboard tests, but as a first step I'd like to remove the underscore-prefix from the file names if others don't mind.

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor Author

spalger commented Mar 7, 2019

7.x/7.1: 497134f
7.0: 2e3df6e

@spalger spalger deleted the remove-underscore-prefix branch March 7, 2019 04:51
PhilippBaranovskiy pushed a commit to PhilippBaranovskiy/kibana that referenced this pull request Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants