[Maps] Move tooltips to store #32333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmp commit tmp commit remove usage from vector layer
thomasneirynck
added
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis |
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
|
jenkins, test this |
💔 Build Failed |
|
wrt. #32560 . I'd like to do this in separate PR. I don't want to clutter this too much. |
nreese
reviewed
Mar 6, 2019
| } | ||
|
|
||
| const targetFeature = features[0]; | ||
| if (this.props.tooltipState) { |
There was a problem hiding this comment.
Do we need this check. Should we update the tooltip lat/lon as the user continues to move inside of large features?
There was a problem hiding this comment.
I wouldn't. It's not doing that now either.
It's getting to video-game-ish when it does move with pointer imho. When we do the on-click handling, we might want to put the tooltip at the place of click/center of feature,...
nreese
reviewed
Mar 6, 2019
nreese
reviewed
Mar 6, 2019
nreese
reviewed
Mar 6, 2019
💚 Build Succeeded |
💚 Build Succeeded |
nreese
approved these changes
Mar 7, 2019
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Mar 7, 2019
This is an internal refactor: - move tooltip management out of layers, and to the mapbox-component - use global handler iso of multiple handlers on individual layers (this did remove the cursor-pointer change, since we no longer are explicitly handling on-enter/leave events). - put tooltip state in store Fixes bugs: - when layer is removed, any corresponding tooltip should be removed as well - when layer is made invisible, any corresponding tooltip should be removed as well
PhilippBaranovskiy
pushed a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
This is an internal refactor: - move tooltip management out of layers, and to the mapbox-component - use global handler iso of multiple handlers on individual layers (this did remove the cursor-pointer change, since we no longer are explicitly handling on-enter/leave events). - put tooltip state in store Fixes bugs: - when layer is removed, any corresponding tooltip should be removed as well - when layer is made invisible, any corresponding tooltip should be removed as well
thomasneirynck
added a commit
that referenced
this pull request
Mar 7, 2019
This is an internal refactor: - move tooltip management out of layers, and to the mapbox-component - use global handler iso of multiple handlers on individual layers (this did remove the cursor-pointer change, since we no longer are explicitly handling on-enter/leave events). - put tooltip state in store Fixes bugs: - when layer is removed, any corresponding tooltip should be removed as well - when layer is made invisible, any corresponding tooltip should be removed as well
6 tasks
nreese
added
the
release_note:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an internal refactor:
This needs to fix some bugs
Separate PRs will be submitted to extend tooltip functionality, which should include: