Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dummy function to avoid warning. #32070

Merged
merged 3 commits into from
Mar 7, 2019

Conversation

ganeshpatro321
Copy link
Contributor

@ganeshpatro321 ganeshpatro321 commented Feb 26, 2019

Summary

Resolves #31527.

This PR will avoid required prop warning for EuiSearchBar component.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ganeshpatro321
Copy link
Contributor Author

@justinkambic please review this PR. for the issue #31527

@justinkambic justinkambic added v7.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 v7.2.0 labels Feb 27, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime

@justinkambic justinkambic added the bug Fixes for quality problems that affect the customer experience label Feb 27, 2019
@justinkambic justinkambic self-requested a review February 27, 2019 14:48
@justinkambic justinkambic self-assigned this Feb 27, 2019
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! This looks good to me; I suggested we add a comment to the function explaining why it's there and the reason for the empty function.

One other thing, please run prettier on the file as the current formatting will likely break our CI.

@ganeshpatro321
Copy link
Contributor Author

ganeshpatro321 commented Feb 28, 2019

Okay @justinkambic, sorry for the late reply. I had problem with my laptop, so couldnt be active, I will review this and update the PR.

Thank You!

Co-Authored-By: ganeshpatro321 <[email protected]>
@ganeshpatro321
Copy link
Contributor Author

@justinkambic Please review this.

@justinkambic justinkambic requested a review from andrewvc March 1, 2019 14:44
@justinkambic
Copy link
Contributor

jenkins test this

@justinkambic
Copy link
Contributor

@ganeshpatro321 I've kicked off a CI build; if that passes we will be in pretty good shape.

I also included @andrewvc if he'd like to review as well.

Please feel free to ping either of us on this PR if you have further questions.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@justinkambic
Copy link
Contributor

justinkambic commented Mar 1, 2019

@ganeshpatro321 it looks like we're failing CI because the code formatting doesn't comply.

See console output here.

Can you please run prettier on the file? This will format it correctly. It looks like the rest of the CI jobs passed so once the formatting is updated we will be good to go.

@ganeshpatro321
Copy link
Contributor Author

ganeshpatro321 commented Mar 1, 2019

Okay @justinkambic

@ganeshpatro321
Copy link
Contributor Author

@justinkambic Please run the CI again.

@justinkambic
Copy link
Contributor

jenkins test this

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution!

Code reviewed, locally tested, the loading state warning no longer appears:
image

@ganeshpatro321
Copy link
Contributor Author

Great!😃

@andrewvc andrewvc merged commit 89a89e3 into elastic:master Mar 7, 2019
@andrewvc
Copy link
Contributor

andrewvc commented Mar 7, 2019

Merged! Thanks @ganeshpatro321

andrewvc pushed a commit to andrewvc/kibana that referenced this pull request Mar 7, 2019
andrewvc pushed a commit to andrewvc/kibana that referenced this pull request Mar 7, 2019
andrewvc pushed a commit to andrewvc/kibana that referenced this pull request Mar 7, 2019
andrewvc added a commit that referenced this pull request Mar 7, 2019
andrewvc added a commit that referenced this pull request Mar 7, 2019
andrewvc added a commit that referenced this pull request Mar 7, 2019
PhilippBaranovskiy pushed a commit to PhilippBaranovskiy/kibana that referenced this pull request Mar 7, 2019
@justinkambic justinkambic changed the title Added dummy fucntion to avoid warning. Added dummy function to avoid warning. Mar 8, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport pending bug Fixes for quality problems that affect the customer experience Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v6.7.0 v7.0.0 v7.2.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants