-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dummy function to avoid warning. #32070
Conversation
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@justinkambic please review this PR. for the issue #31527 |
Pinging @elastic/uptime |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! This looks good to me; I suggested we add a comment to the function explaining why it's there and the reason for the empty function.
One other thing, please run prettier on the file as the current formatting will likely break our CI.
x-pack/plugins/uptime/public/components/functional/filter_bar_loading.tsx
Outdated
Show resolved
Hide resolved
Okay @justinkambic, sorry for the late reply. I had problem with my laptop, so couldnt be active, I will review this and update the PR. Thank You! |
Co-Authored-By: ganeshpatro321 <[email protected]>
@justinkambic Please review this. |
jenkins test this |
@ganeshpatro321 I've kicked off a CI build; if that passes we will be in pretty good shape. I also included @andrewvc if he'd like to review as well. Please feel free to ping either of us on this PR if you have further questions. |
💔 Build Failed |
@ganeshpatro321 it looks like we're failing CI because the code formatting doesn't comply. See console output here. Can you please run prettier on the file? This will format it correctly. It looks like the rest of the CI jobs passed so once the formatting is updated we will be good to go. |
Okay @justinkambic |
@justinkambic Please run the CI again. |
jenkins test this |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!😃 |
Merged! Thanks @ganeshpatro321 |
Co-Authored-By: ganeshpatro321 <[email protected]>
Co-Authored-By: ganeshpatro321 <[email protected]>
Co-Authored-By: ganeshpatro321 <[email protected]>
Co-Authored-By: ganeshpatro321 <[email protected]>
Co-Authored-By: ganeshpatro321 <[email protected]>
Co-Authored-By: ganeshpatro321 <[email protected]>
Co-Authored-By: ganeshpatro321 <[email protected]>
💔 Build Failed |
Summary
Resolves #31527.
This PR will avoid required prop warning for EuiSearchBar component.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers