[ML] Fix chart tooltip positioning for new K7 navigation #32563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
non-issue
peteharverson
requested review from
walterra,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
walterra
approved these changes
Mar 6, 2019
| } | ||
| const top = pos.top + (offset.y) + scrollTop - 75; // Subtract 75 to adjust for height of top nav |
There was a problem hiding this comment.
Instead of using the comment for clarifying, this refactor might be an opportunity to first assign the raw number to a more self explanatory variable (see https://github.com/elastic/kibana/blob/master/style_guides/js_style_guide.md#magic-numbersstrings). Could also be done for the 22 two lines above.
There was a problem hiding this comment.
Good call. I've moved those two numbers into variables
💔 Build Failed |
💚 Build Succeeded |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 6, 2019
* [ML] Fix chart tooltip positioning for new K7 navigation * [ML] Move numeric offset numbers into variables
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
Mar 6, 2019
* [ML] Fix chart tooltip positioning for new K7 navigation * [ML] Move numeric offset numbers into variables
peteharverson
added a commit
that referenced
this pull request
Mar 6, 2019
peteharverson
added a commit
that referenced
this pull request
Mar 6, 2019
PhilippBaranovskiy
pushed a commit
to PhilippBaranovskiy/kibana
that referenced
this pull request
Mar 7, 2019
* [ML] Fix chart tooltip positioning for new K7 navigation * [ML] Move numeric offset numbers into variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the offsets used to position the chart tooltips to account for the switch from the kui side and top navigation bars in 6.x to the new K7 navigation elements.
Before:
After:
Checklist