Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Auto button inside Chart style should read "Color: Auto" #32632

Closed
wants to merge 28 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
f786f20
[ML] (Accessibility) "Analyzing Data" should announce
PhilippBaranovskiy Mar 5, 2019
b83cc28
add aria label for current auto (not set) color
PhilippBaranovskiy Mar 6, 2019
30795ad
attempts to get intl working
PhilippBaranovskiy Mar 7, 2019
3f030d8
fixing pipeline_data_loader (#32478)
ppisljar Mar 6, 2019
5461894
Fix some strings after translator feedback (#32501)
timroes Mar 6, 2019
290a58e
[Infra UI] Add Legend Settings for Waffle Map (#32228)
simianhacker Mar 6, 2019
d2bc6b0
[CCR] Fix form bug + add missing i18n (#32544)
sebelga Mar 6, 2019
3f24ccc
Typescript-ify FTR Remote (#32447)
Mar 6, 2019
5463a69
Reenable auth provider tests (#32565)
kobelb Mar 6, 2019
610495b
[ML] Fix chart tooltip positioning for new K7 navigation (#32563)
peteharverson Mar 6, 2019
e1dcdc8
[DOCS] Adds tagged region for notable breaking changes (#30155)
lcawl Mar 6, 2019
191c2f4
[dashboard/ftr] disable panelCount assertions (#32579)
Mar 6, 2019
4e4b773
[dashboard/ftr] remove _-prefix from file names (#32585)
Mar 6, 2019
5c5675b
[ftr] determine oss ciGroups by reading the yaml file (#32575)
Mar 6, 2019
f801954
Be able to delete watch_optimizer_cache_state.json when data folder i…
zfy0701 Mar 6, 2019
f74b70f
Fix common router request handler issue (#32275)
jen-huang Mar 6, 2019
ed3a807
Fix API endpoint typo indices/clear_caches -> indices/clear_cache. (#…
cjcenizal Mar 6, 2019
d1d26db
[Maps] Localization (#30881)
thomasneirynck Mar 6, 2019
c2c715f
download oss version of kibana in packer cache script (#32588)
Mar 7, 2019
751d0de
Added dummy fucntion to avoid warning. (#32070)
ganeshpatro321 Mar 7, 2019
a87061a
[Maps] Move tooltips to store (#32333)
thomasneirynck Mar 7, 2019
41adcfd
Initial unit tests for embedded_visualize_handler (#31324)
lukeelmers Mar 7, 2019
7298fc1
Revert "Initial unit tests for embedded_visualize_handler" (#32615)
Mar 7, 2019
9d7cfa5
[deprecation warnings] Use of the joda time method [getHourOfDay()] i…
alexwizp Mar 7, 2019
3ad1c09
[TSVB] Incorrect behavior when filling the 'interval' field with valu…
alexwizp Mar 7, 2019
c93e170
TSVB display interval information when building (#32117)
alexwizp Mar 7, 2019
8270ceb
Merge branch 'master' into 25508
PhilippBaranovskiy Mar 7, 2019
fc06cdd
since xpack.canvas label is not on the list of translated plugins, i …
PhilippBaranovskiy Mar 7, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .ci/jobs.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
JOB:
- kibana-intake
- x-pack-intake
# make sure all kibana-ciGRoups are listed in tasks/function_test_groups.js
- kibana-ciGroup1
- kibana-ciGroup2
- kibana-ciGroup3
Expand Down
1 change: 1 addition & 0 deletions .ci/packer_cache.sh
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ source src/dev/ci_setup/setup.sh;

# download es snapshots
node scripts/es snapshot --download-only;
node scripts/es snapshot --license=oss --download-only;

# download reporting browsers
cd "x-pack";
Expand Down
1 change: 1 addition & 0 deletions .i18nrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
"xpack.infra": "x-pack/plugins/infra",
"xpack.kueryAutocomplete": "x-pack/plugins/kuery_autocomplete",
"xpack.licenseMgmt": "x-pack/plugins/license_management",
"xpack.maps": "x-pack/plugins/maps",
"xpack.ml": "x-pack/plugins/ml",
"xpack.logstash": "x-pack/plugins/logstash",
"xpack.main": "x-pack/plugins/xpack_main",
Expand Down
9 changes: 9 additions & 0 deletions docs/migration/migrate_8_0.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,12 @@ your application to Kibana 8.0.
coming[8.0.0]

See also <<release-highlights>> and <<release-notes>>.

////
The following section is re-used in the Installation and Upgrade Guide
[[breaking_80_notable]]
=== Notable breaking changes
////
// tag::notable-breaking-changes[]

// end::notable-breaking-changes[]
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,7 @@
"@types/bluebird": "^3.1.1",
"@types/boom": "^7.2.0",
"@types/chance": "^1.0.0",
"@types/chromedriver": "^2.38.0",
"@types/classnames": "^2.2.3",
"@types/d3": "^3.5.41",
"@types/dedent": "^0.7.0",
Expand Down
17 changes: 11 additions & 6 deletions packages/kbn-test/types/ftr.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@
* under the License.
*/

import { DefaultServiceProviders } from '../../../src/functional_test_runner/types';
import { ToolingLog } from '@kbn/dev-utils';
import { Config, Lifecycle } from '../../../src/functional_test_runner/lib';

interface AsyncInstance<T> {
/**
Expand All @@ -39,22 +40,23 @@ type MaybeAsyncInstance<T> = T extends Promise<infer X> ? AsyncInstance<X> & X :
* Convert a map of providers to a map of the instance types they provide, also converting
* promise types into the async instances that other providers will receive.
*/
type ProvidedTypeMap<T extends object> = {
type ProvidedTypeMap<T extends {}> = {
[K in keyof T]: T[K] extends (...args: any[]) => any
? MaybeAsyncInstance<ReturnType<T[K]>>
: never
: unknown
};

export interface GenericFtrProviderContext<
ServiceProviders extends object,
PageObjectProviders extends object,
ServiceMap = ProvidedTypeMap<ServiceProviders & DefaultServiceProviders>,
ServiceProviders extends {},
PageObjectProviders extends {},
ServiceMap = ProvidedTypeMap<ServiceProviders>,
PageObjectMap = ProvidedTypeMap<PageObjectProviders>
> {
/**
* Determine if a service is avaliable
* @param serviceName
*/
hasService(serviceName: 'config' | 'log' | 'lifecycle'): true;
hasService<K extends keyof ServiceMap>(serviceName: K): serviceName is K;
hasService(serviceName: string): serviceName is keyof ServiceMap;

Expand All @@ -63,6 +65,9 @@ export interface GenericFtrProviderContext<
* outside of a test/hook, then make sure to call its `.init()` method and await it's promise.
* @param serviceName
*/
getService(serviceName: 'config'): Config;
getService(serviceName: 'log'): ToolingLog;
getService(serviceName: 'lifecycle'): Lifecycle;
getService<T extends keyof ServiceMap>(serviceName: T): ServiceMap[T];

/**
Expand Down
27 changes: 0 additions & 27 deletions src/functional_test_runner/types.ts

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ exports[`renders OptionsTab 1`] = `
data-test-subj="inputControlEditorPinFiltersCheckbox"
label={
<FormattedMessage
defaultMessage="Pin filters to global state"
defaultMessage="Pin filters for all applications"
id="inputControl.editor.optionsTab.pinFiltersLabel"
values={Object {}}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class OptionsTab extends Component {
<EuiSwitch
label={<FormattedMessage
id="inputControl.editor.optionsTab.pinFiltersLabel"
defaultMessage="Pin filters to global state"
defaultMessage="Pin filters for all applications"
/>}
checked={this.props.editorState.params.pinFilters}
onChange={this.handlePinFilters}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export const visualization = () => ({

handlers.onDestroy(() => visualizationLoader.destroy());

await visualizationLoader.render(domNode, handlers.vis, visData, uiState, params).then(() => {
await visualizationLoader.render(domNode, handlers.vis, visData, visConfig || handlers.vis.params, uiState, params).then(() => {
if (handlers.done) handlers.done();
});
},
Expand Down
18 changes: 0 additions & 18 deletions src/legacy/core_plugins/kibana/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,6 @@ export default function (kibana) {
id: 'kibana',
title: 'Kibana',
listed: false,
description: i18n.translate('kbn.kibanaDescription', {
defaultMessage: 'the kibana you know and love'
}),
main: 'plugins/kibana/kibana',
},
styleSheetPaths: resolve(__dirname, 'public/index.scss'),
Expand All @@ -83,9 +80,6 @@ export default function (kibana) {
}),
order: -1003,
url: `${kbnBaseUrl}#/discover`,
description: i18n.translate('kbn.discoverDescription', {
defaultMessage: 'interactively explore your data'
}),
icon: 'plugins/kibana/assets/discover.svg',
euiIconType: 'discoverApp',
}, {
Expand All @@ -95,9 +89,6 @@ export default function (kibana) {
}),
order: -1002,
url: `${kbnBaseUrl}#/visualize`,
description: i18n.translate('kbn.visualizeDescription', {
defaultMessage: 'design data visualizations'
}),
icon: 'plugins/kibana/assets/visualize.svg',
euiIconType: 'visualizeApp',
}, {
Expand All @@ -113,9 +104,6 @@ export default function (kibana) {
// the url above in order to preserve the original url for BWC. The subUrlBase helps the Chrome api nav
// to determine what url to use for the app link.
subUrlBase: `${kbnBaseUrl}#/dashboard`,
description: i18n.translate('kbn.dashboardDescription', {
defaultMessage: 'compose visualizations for much win'
}),
icon: 'plugins/kibana/assets/dashboard.svg',
euiIconType: 'dashboardApp',
}, {
Expand All @@ -125,9 +113,6 @@ export default function (kibana) {
}),
order: 9001,
url: '/app/kibana#/dev_tools',
description: i18n.translate('kbn.devToolsDescription', {
defaultMessage: 'development tools'
}),
icon: 'plugins/kibana/assets/wrench.svg',
euiIconType: 'devToolsApp',
}, {
Expand All @@ -137,9 +122,6 @@ export default function (kibana) {
}),
order: 9003,
url: `${kbnBaseUrl}#/management`,
description: i18n.translate('kbn.managementDescription', {
defaultMessage: 'define index patterns, change config, and more'
}),
icon: 'plugins/kibana/assets/settings.svg',
euiIconType: 'managementApp',
linkToLastSubUrl: false
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ class DashboardPanelUi extends React.Component<DashboardPanelUiProps, State> {
? null
: props.intl.formatMessage({
id: 'kbn.dashboard.panel.noEmbeddableFactoryErrorMessage',
defaultMessage: 'No factory found for embeddable',
defaultMessage: 'The feature to render this panel is missing.',
}),
};

Expand Down
4 changes: 2 additions & 2 deletions src/legacy/core_plugins/metrics/common/interval_regexp.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
*/

import dateMath from '@elastic/datemath';
export const GTE_INTERVAL_RE = new RegExp(`^>=([\\d\\.]*\\s*(${dateMath.units.join('|')}))$`);
export const INTERVAL_STRING_RE = new RegExp('^([0-9\\.]*)\\s*(' + dateMath.units.join('|') + ')$');
export const GTE_INTERVAL_RE = new RegExp(`^>=([\\d\\.]+\\s*(${dateMath.units.join('|')}))$`);
export const INTERVAL_STRING_RE = new RegExp(`^([\\d\\.]+)\\s*(${dateMath.units.join('|')})$`);

94 changes: 94 additions & 0 deletions src/legacy/core_plugins/metrics/common/interval_regexp.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,94 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { GTE_INTERVAL_RE, INTERVAL_STRING_RE } from './interval_regexp';

describe('interval_regexp', () => {
describe('GTE_INTERVAL_RE', () => {
test('returns true for">=12h"', () => {
const value = GTE_INTERVAL_RE.test('>=12h');

expect(value).toBeTruthy();
});
test('returns true for ">=1y"', () => {
const value = GTE_INTERVAL_RE.test('>=12h');

expect(value).toBeTruthy();
});
test('returns true for ">=25m"', () => {
const value = GTE_INTERVAL_RE.test('>=12h');

expect(value).toBeTruthy();
});
test('returns false "auto"', () => {
const value = GTE_INTERVAL_RE.test('auto');

expect(value).toBeFalsy();
});
test('returns false "wrongInput"', () => {
const value = GTE_INTERVAL_RE.test('wrongInput');

expect(value).toBeFalsy();
});
test('returns false "d"', () => {
const value = GTE_INTERVAL_RE.test('d');

expect(value).toBeFalsy();
});

test('returns false "y"', () => {
const value = GTE_INTERVAL_RE.test('y');

expect(value).toBeFalsy();
});
});

describe('INTERVAL_STRING_RE', () => {
test('returns true for "8d"', () => {
const value = INTERVAL_STRING_RE.test('8d');

expect(value).toBeTruthy();
});
test('returns true for "1y"', () => {
const value = INTERVAL_STRING_RE.test('1y');

expect(value).toBeTruthy();
});
test('returns true for "6M"', () => {
const value = INTERVAL_STRING_RE.test('6M');

expect(value).toBeTruthy();
});
test('returns false "auto"', () => {
const value = INTERVAL_STRING_RE.test('auto');

expect(value).toBeFalsy();
});
test('returns false "wrongInput"', () => {
const value = INTERVAL_STRING_RE.test('wrongInput');

expect(value).toBeFalsy();
});
test('returns false for">=21h"', () => {
const value = INTERVAL_STRING_RE.test('>=21h');

expect(value).toBeFalsy();
});
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ export const IndexPattern = props => {
disabled={props.disabled}
onChange={handleTextChange(intervalName, 'auto')}
value={model[intervalName]}
placeholder={'auto'}
/>
</EuiFormRow>
</EuiFlexItem>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,20 @@
* specific language governing permissions and limitations
* under the License.
*/

import { relativeOptions } from '../../../../../ui/public/timepicker/relative_options';
import _ from 'lodash';
import moment from 'moment';
import { convertIntervalIntoUnit } from './get_interval';
import { i18n } from '@kbn/i18n';

const unitLookup = {
s: i18n.translate('tsvb.axisLabelOptions.secondsLabel', { defaultMessage: 'seconds' }),
m: i18n.translate('tsvb.axisLabelOptions.minutesLabel', { defaultMessage: 'minutes' }),
h: i18n.translate('tsvb.axisLabelOptions.hoursLabel', { defaultMessage: 'hours' }),
d: i18n.translate('tsvb.axisLabelOptions.daysLabel', { defaultMessage: 'days' }),
w: i18n.translate('tsvb.axisLabelOptions.weeksLabel', { defaultMessage: 'weeks' }),
M: i18n.translate('tsvb.axisLabelOptions.monthsLabel', { defaultMessage: 'months' }),
y: i18n.translate('tsvb.axisLabelOptions.yearsLabel', { defaultMessage: 'years' })
};
export function getAxisLabelString(interval) {
const units = _.pluck(_.clone(relativeOptions).reverse(), 'value')
.filter(s => /^[smhdwMy]$/.test(s));
const duration = moment.duration(interval, 'ms');
for (let i = 0; i < units.length; i++) {
const as = duration.as(units[i]);
if (Math.abs(as) > 1) {
const unitValue = Math.round(Math.abs(as));
const unitString = unitLookup[units[i]];
return i18n.translate('tsvb.axisLabelOptions.axisLabel',
{ defaultMessage: 'per {unitValue} {unitString}', values: { unitValue, unitString } });
}
const convertedValue = convertIntervalIntoUnit(interval);

if (convertedValue) {
return i18n.translate('tsvb.axisLabelOptions.axisLabel',
{
defaultMessage: 'per {unitValue} {unitString}',
values: {
unitValue: convertedValue.unitValue,
unitString: convertedValue.unitString,
},
});
}
}
Loading