Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work list of additions and fixes to test infrastructure by StyleCop Analyzers #123

Closed
sharwell opened this issue May 28, 2018 · 2 comments
Closed

Work list of additions and fixes to test infrastructure by StyleCop Analyzers #123

sharwell opened this issue May 28, 2018 · 2 comments

Comments

@sharwell
Copy link
Member

sharwell commented May 28, 2018 •
edited
Loading

The current source-based distribution of the testing framework leads to large discrepancies between various testing strategies available for new analyzers. The following is a list of specific changes made to the source by the StyleCop Analyzers project which can be considered for incorporation here during the work to distribute the test infrastructure as a shared library (#20).

📝 This list only includes changes through 2 November 2017.

Features added by StyleCop Analyzers

Features added by @JohanLarsson:

One of the remaining significant challenges is writing test inputs and outputs as strings, and then relating positions within those strings to the expected diagnostics positions. Johan has done substantial work to improve this experience.

The main limiting factor with the assertions library (last time I reviewed) is it doesn't support all of the testing features analyzer libraries may need. There is also a usability concern related to the use of Unicode arrows as delimiters. Specific limitations which should be considered and addressed if possible are:

  • Overlapping diagnostic spans
  • Diagnostics with different IDs reported within a single test
  • Assertions relating to specific messages and/or severities reported with diagnostics
@jmarolf
Copy link
Contributor

jmarolf commented May 28, 2018

Thanks for this @sharwell

@sharwell
Copy link
Member Author

@jmarolf No problem. It will be really nice to get all of this in a shared library. On multiple occasions even I've had trouble starting a new analyzer project due to the differences between approaches. It will be really nice to unify everything so I can stop having to worry about synchronizing concepts everywhere.

This was referenced Aug 9, 2018
Merged
Closed
@sharwell sharwell closed this as completed Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add diagnostic and code fix verification helpers sharwell/roslyn-sdk
2 participants
@sharwell @jmarolf