Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test all fix all providers #1126

Merged
merged 6 commits into from
Aug 6, 2015
Merged

Conversation

pdelvo
Copy link
Member

@pdelvo pdelvo commented Aug 5, 2015

With this PR all code fix tests will also try to verify that the fix all provider works correctly. This is WIP because of some test failures.

@sharwell sharwell self-assigned this Aug 6, 2015
This parameter allows test code to specify a separate result for the batch
fixer, in the event it differs from the final result of incrementally
applying code fixes.
@pdelvo
Copy link
Member Author

pdelvo commented Aug 6, 2015

@sharwell I merged your PR

@sharwell
Copy link
Member

sharwell commented Aug 6, 2015

Edit: The remaining test which fails only fails intermittently. Sometimes the output from the batch fixer matches fixedTestCode, and sometimes it does not.

@sharwell sharwell added this to the 1.0.0 Beta 4 milestone Aug 6, 2015
@sharwell
Copy link
Member

sharwell commented Aug 6, 2015

I'm going to disable the failing test if it continues to fail after #1122.

@sharwell sharwell changed the title WIP: Test all fix all providers Test all fix all providers Aug 6, 2015
sharwell added a commit that referenced this pull request Aug 6, 2015
@sharwell sharwell merged commit 0ab10c8 into DotNetAnalyzers:master Aug 6, 2015
@pdelvo pdelvo deleted the testallfixall branch August 27, 2015 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants