Improve concurrency behavior of the generated code cache #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Nice |
|
I'm marking this as blocked on #610 for a bit. I rebased and cleaned up that branch last night and I want to discuss it before having to go through that again. 😄 |
sharwell
added a commit
that referenced
this pull request
Aug 29, 2015
Improve concurrency behavior of the generated code cache
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a 28-core machine analyzing Roslyn.sln, the concurrent profiler reported an 85% reduction in the number of contentions inside of
IsGeneratedDocument, and an 83% reduction in the amount of time threads were blocked inside this method.This pull request also converts analysis methods to be static where possible.