Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable tests for code fix behavior with alternate indentation #1135

Merged
merged 2 commits into from
Aug 6, 2015

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Aug 6, 2015

I was able to address the original reliability problems by disabling test parallelization. It did not appear to have an effect on the overall build and test time.

The per-language options used by the AdhocWorkspace are currently shared.
This is caused by the default constructor of AdhocWorkspace using
MefHostServices.DefaultHost to provide workspace services, combined with
Workspace.WithChangedOption setting values back to the host.

In theory, all tests which run using the default options could be run in
parallel, and only serialize the tests which use custom options. However,
we don't have a mechanism in place to handle this currently, so disabling
test parallelization allows us to improve overall test quality immediately
(by testing alternate indentation options in some scenarios).
@Noryoko
Copy link
Contributor

Noryoko commented Aug 6, 2015

👍

@sharwell sharwell added this to the 1.0.0 Beta 4 milestone Aug 6, 2015
sharwell added a commit that referenced this pull request Aug 6, 2015
Enable tests for code fix behavior with alternate indentation
@sharwell sharwell merged commit b826eda into DotNetAnalyzers:master Aug 6, 2015
@sharwell sharwell deleted the indentation-tests branch August 6, 2015 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants