Update spacing rules for C# 7 #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
+ Coverage 95.3% 95.44% +0.14%
==========================================
Files 664 675 +11
Lines 87833 89486 +1653
Branches 3428 3431 +3
==========================================
+ Hits 83709 85411 +1702
+ Misses 3206 3154 -52
- Partials 918 921 +3
Continue to review full report at Codecov.
|
sharwell
commented
Jun 11, 2017
| case SyntaxKind.SelectKeyword: | ||
| case SyntaxKind.StackAllocKeyword: | ||
| case SyntaxKind.SwitchKeyword: | ||
| case SyntaxKind.UsingKeyword: | ||
| case SyntaxKind.TypeVarKeyword: |
There was a problem hiding this comment.
❗️ this is the typevar keyword used as an attribute location, not the var keyword I intended.
sharwell
force-pushed
the
csharp7-spacing
branch
from
9ebf8a3 to
57a8b93
Compare
sharwell
force-pushed
the
csharp7-spacing
branch
from
e84bdca to
f2e2cbd
Compare
sharwell
changed the title
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2267
Fixes #2308
outkeyword foroutvariablesrefkeyword for ref locals and expressionsvarkeyword=>refexpressions]before a comma in a tuple type(int[], int)}before a comma in tuple expression(new[] { 3 }, 3)>before a comma or closing parenthesis in tuple type(Func<int>, Func<int>)(int, int)?(x: 3, y: 4)