#2308 - SA1008 triggered by typle return types on a method - fixed

[Nozziel]

#2308 - SA1008 triggered by typle return types on a method (c# version 7) - Fixed

Note: unit tests created but wont work without System.ValueTuple nuget package so set to Skip atm..

[codecov]

Codecov Report

Merging #2319 into master will decrease coverage by 0.13%.
The diff coverage is 1.88%.

@@            Coverage Diff             @@
##           master    #2319      +/-   ##
==========================================
- Coverage   96.86%   96.72%   -0.14%     
==========================================
  Files         598      598              
  Lines       84083    84409     +326     
  Branches     3207     3213       +6     
==========================================
+ Hits        81444    81642     +198     
- Misses       1774     1853      +79     
- Partials      865      914      +49

Impacted Files	Coverage Δ
...Cop.Analyzers.Test/SpacingRules/SA1008UnitTests.cs	97.02% <0%> (-2.98%)	⬇️
...s/SA1008OpeningParenthesisMustBeSpacedCorrectly.cs	97.87% <100%> (-2.13%)	⬇️
...eCop.Analyzers/Helpers/ObjectPools/ObjectPool`1.cs	57.4% <0%> (-29.63%)	⬇️
...nalyzers/StyleCop.Analyzers.Test/PublicApiTests.cs	33.33% <0%> (-8.34%)	⬇️
...eCop.Analyzers/Helpers/LiteralExpressionHelpers.cs	60% <0%> (-6.67%)	⬇️
...zers/ReadabilityRules/SA1121UseBuiltInTypeAlias.cs	92.2% <0%> (-3.9%)	⬇️
...eFixes/DocumentationRules/SA1649CodeFixProvider.cs	81.81% <0%> (-3.04%)	⬇️
...ers.CodeFixes/NamingRules/SA1308CodeFixProvider.cs	94.44% <0%> (-2.78%)	⬇️
...eferenceAndAccessOfSymbolsMustBeSpacedCorrectly.cs	93.42% <0%> (-2.64%)	⬇️
...p.Analyzers/Helpers/UsingDirectiveSyntaxHelpers.cs	92.1% <0%> (-2.64%)	⬇️
... and 45 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493390a...1c49cb2. Read the comment docs.

[vweijsters]

Labeling this do not merge until it is clear how / when we are going to use CodeAnalysis 2.0

[sharwell]

Thank you for the submission @Nozziel. After a large amount of struggling over how to handle C# 7 in upcoming releases of these analyzers, I finally settled on a pattern which allows us to continue fully supporting C# 6 users. During this work (specifically my next push to pull request #2389), I updated the spacing rules to work with C# 7 and resolved #2308 as part of that. There is still a fair amount of work to do before C# 7 support is fully complete, but I really hope to finish with all the updates soon!