Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async cleanup #550

Merged
merged 3 commits into from
Apr 23, 2015
Merged

Async cleanup #550

merged 3 commits into from
Apr 23, 2015

Conversation

sharwell
Copy link
Member

Considering the number of lines changed, I encourage you to look at the individual commits.

  • Use ConfigureAwait(false) with all await operations (automated detection and refactoring per Code Cracker CC0070).
  • Pass a CancellationToken to asynchronous methods when available and supported.
  • Rename asynchronous methods with the Async suffix (automated detection and refactoring per Code Cracker CC0061).

@sharwell sharwell added this to the 1.0.0 Alpha 5 milestone Mar 20, 2015
@pdelvo pdelvo mentioned this pull request Mar 21, 2015
Merged
@vweijsters
Copy link
Contributor

👍 I see no anomalies, lets merge this.

@sharwell sharwell merged commit 523908f into DotNetAnalyzers:master Apr 23, 2015
sharwell added a commit that referenced this pull request Apr 23, 2015
@sharwell
Merge pull request #550 from sharwell/async-cleanup
aa3d45d
@sharwell sharwell deleted the async-cleanup branch April 23, 2015 01:30
@sharwell sharwell assigned sharwell and vweijsters and unassigned sharwell Apr 23, 2015
@sharwell sharwell mentioned this pull request May 28, 2018
Closed
@sharwell sharwell mentioned this pull request Aug 14, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vweijsters vweijsters

Labels
enhancement fixed
Projects
None yet
Milestone
1.0.0 Alpha 5
Development

Successfully merging this pull request may close these issues.
2 participants
@sharwell @vweijsters