Implement new diagnostic SA1652 (EnableXmlDocumentationOutput) #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| if (context.Tree.Options.DocumentationMode == DocumentationMode.None) | ||
| { | ||
| context.ReportDiagnostic(Diagnostic.Create(Descriptor, context.Tree.GetLocation(new TextSpan(0, 0)))); |
There was a problem hiding this comment.
Do we really want to report a diagnostic on every SyntaxTree?
There was a problem hiding this comment.
Maybe, maybe not. Since the documentation mode is a property of each SyntaxTree, I figured this makes sense at least until someone has a major problem with it.
sharwell
force-pushed
the
implement-sa1652
branch
from
a6602b0 to
886f05d
Compare
sharwell
force-pushed
the
implement-sa1652
branch
from
886f05d to
965be0e
Compare
| { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
No way to avoid the repetition of these?
There was a problem hiding this comment.
Not without additional refactoring. Each of these methods is its own entry and exit point for analysis of a particular type of syntax node.
|
👍 |
sharwell
added a commit
that referenced
this pull request
Jul 28, 2015
Implement new diagnostic SA1652 (EnableXmlDocumentationOutput)
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1053.