Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary diagnostic id checks #1625

Merged
merged 1 commit into from
Oct 14, 2015

Conversation

vweijsters
Copy link
Contributor

This is part 1 of the breakup of #1452

@codecov-io
Copy link

Current coverage is 79.75%

Merging #1625 into master will increase coverage by +0.21% as of 24bd74c

@@            master   #1625   diff @@
======================================
  Files          531     531       
  Stmts        31617   31536    -81
  Branches      8865    8838    -27
  Methods                          
======================================
+ Hit          25150   25153     +3
+ Partial       5165    5137    -28
+ Missed        1302    1246    -56

Review entire Coverage Diff as of 24bd74c

Powered by Codecov. Updated on successful CI builds.

@Maxwe11
Copy link
Member

Maxwe11 commented Oct 14, 2015

:shipit:

@sharwell
Copy link
Member

Why are we not seeing an AppVeyor build failure due to the SA1513 test?

@sharwell
Copy link
Member

Ah, looks like that test only runs the code fix, but doesn't have the assertions for diagnostics reported before/after the fix.

@sharwell sharwell added this to the 1.0.0 Beta 14 milestone Oct 14, 2015
sharwell added a commit that referenced this pull request Oct 14, 2015
Removed unnecessary diagnostic id checks
@sharwell sharwell merged commit 68e55fc into DotNetAnalyzers:master Oct 14, 2015
@sharwell
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants