Cleanup for code fixes #1452
Cleanup for code fixes #1452
Conversation
|
I find myself wishing this was multiple commits:
|
| } | ||
| while (false); | ||
| "; | ||
|
|
||
| await this.VerifyCSharpFixAsync(testCode, fixedTestCode).ConfigureAwait(false); | ||
| await this.VerifyCSharpFixAsync(testCode, fixedTestCode, allowUnsupportedDiagnostics: true).ConfigureAwait(false); |
There was a problem hiding this comment.
❓ Why did this one need to be a special case? It seems like a bunch of special behavior was added to the testing framework just to support this single test.
There was a problem hiding this comment.
This test contains invalid C# syntax. The closing brace for the method is not present, resulting in a compiler being produced for it in the verify case.
As I wanted to keep the Assert in the CodeFixVerifier signalling that a test case is producing unexpected errors, I had to go to quite a bit of effort to make this test case work.
|
I'll address this in separate pull requests. Keeping this one open until I'm done with those |
|
Closing this as all content has been addressed in other pull requests. |
Refactored all code fixes for consistency, based on discussions in #1441