Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic order needs to consider both location and ID #1741

Merged
merged 1 commit into from
Nov 9, 2015
Merged

Diagnostic order needs to consider both location and ID #1741

merged 1 commit into from
Nov 9, 2015

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Nov 8, 2015

Fixes #1734

@sharwell sharwell added this to the 1.0.0 Beta 16 milestone Nov 8, 2015
@sharwell
Ensure diagnostic order is deterministic in unit tests
af29189 
The diagnostic order now considers both the location and ID as necessary
to produce a deterministic ordering of diagnostics during unit tests.

Fixes DotNetAnalyzers#1734
@codecov-io
Copy link

Current coverage is 79.48%

Merging #1741 into master will decrease coverage by -0.01% as of 55b98f9

@@            master   #1741   diff @@
======================================
  Files          546     546       
  Stmts        32741   32741       
  Branches      9070    9070       
  Methods                          
======================================
- Hit          26028   26023     -5
- Partial       5269    5274     +5
  Missed        1444    1444

Review entire Coverage Diff as of 55b98f9

Powered by Codecov. Updated on successful CI builds.

@vweijsters
Copy link
Contributor

👍 Looks good to me

sharwell added a commit that referenced this pull request Nov 9, 2015
@sharwell
Merge pull request #1741 from sharwell/fix-1734
4b62e31 
Diagnostic order needs to consider both location and ID
@sharwell sharwell merged commit 4b62e31 into DotNetAnalyzers:master Nov 9, 2015
@sharwell sharwell deleted the fix-1734 branch November 9, 2015 20:03
@sharwell sharwell mentioned this pull request May 28, 2018
Closed
@sharwell sharwell mentioned this pull request Aug 14, 2018
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vweijsters vweijsters

Labels
None yet
Projects
None yet
Milestone
1.0.0 Beta 16
Development

Successfully merging this pull request may close these issues.
3 participants
@sharwell @codecov-io @vweijsters