Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DiagnosticVerifier.VerifyDiagnosticResults should cope with non-deterministic Roslyn behavior #1734

Closed
vweijsters opened this issue Nov 7, 2015 · 2 comments
Closed

DiagnosticVerifier.VerifyDiagnosticResults should cope with non-deterministic Roslyn behavior #1734

vweijsters opened this issue Nov 7, 2015 · 2 comments
Assignees
@sharwell
Labels
bug fixed
Milestone
1.0.0 Beta 16

Comments

@vweijsters
Copy link
Contributor

Currently DiagnosticVerifier.VerifyDiagnosticResults does check the order in which expected diagnostics occur. This occasionally leads to failed tests, because the order in which diagnostics are produced by Roslyn is not (always) deterministic at the moment.

Also see dotnet/roslyn#372 and dotnet/roslyn#1506 for details
@sharwell sharwell added this to the 1.0.0 RC 1 milestone Nov 8, 2015
@sharwell
Copy link
Member

sharwell commented Nov 8, 2015

Marking this as a 🐛 since we shouldn't have been making these assumptions from the start.

@sharwell
Copy link
Member

sharwell commented Nov 8, 2015

Grabbed

@sharwell sharwell modified the milestones: 1.0.0 Beta 16, 1.0.0 RC 1 Nov 8, 2015
@sharwell sharwell self-assigned this Nov 8, 2015
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Nov 8, 2015
@sharwell
Diagnostic order needs to consider both location and ID
50b9d4d 
Fixes DotNetAnalyzers#1734
@sharwell sharwell mentioned this issue Nov 8, 2015
Merged
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Nov 9, 2015
@sharwell
Ensure diagnostic order is deterministic in unit tests
af29189 
The diagnostic order now considers both the location and ID as necessary
to produce a deterministic ordering of diagnostics during unit tests.

Fixes DotNetAnalyzers#1734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
bug fixed
Projects
None yet
Milestone
1.0.0 Beta 16
Development

No branches or pull requests
2 participants
@sharwell @vweijsters