fix(ui-library): align hint and error message icons #1059
Conversation
RubirajAccenture
added
the
🦹 needs:reviewers (code)
| @@ -34,6 +34,23 @@ describe('blr-checkbox', () => { | |||
| expect(className).to.contain('input-control'); | |||
| }); | |||
|
|
|||
| it('has error Icon is set to undefined', async () => { | |||
There was a problem hiding this comment.
Please adjust it to it('has error Icon set to undefined'...) [remove 'is'] so that it will be consistency with others.
| ); | ||
|
|
||
| const formCaption = querySelectorDeep('.blr-form-caption', element?.getRootNode() as HTMLElement); | ||
|
|
There was a problem hiding this comment.
Please remove this extra new line.
| BlrRadioGroupRenderFunction({ | ||
| ...sampleParams, | ||
| hasHint: false, | ||
| hasError: false, |
There was a problem hiding this comment.
hasError needs to be true
| BlrRadioRenderFunction({ | ||
| ...sampleParams, | ||
| hasHint: false, | ||
| hasError: false, |
There was a problem hiding this comment.
hasError needs to be true
| const labelWrapper = querySelectorDeep('.label-wrapper', element.getRootNode() as HTMLElement); | ||
| const captionWrapper = querySelectorDeep('.caption-wraper', labelWrapper?.getRootNode() as HTMLElement); | ||
| const formCaption = querySelectorDeep('.blr-form-caption', captionWrapper?.getRootNode() as HTMLElement); | ||
|
|
There was a problem hiding this comment.
This extra new line can be removed for the consistency purpose. Right now they are mixed up.
| BlrTextareaRenderFunction({ | ||
| ...sampleParams, | ||
| hasHint: false, | ||
| hasError: false, |
There was a problem hiding this comment.
hasError needs to be true
|
|
||
| const textarea = querySelectorDeep('textarea', element.getRootNode() as HTMLElement); | ||
| const formCaption = querySelectorDeep('.blr-form-caption', textarea?.getRootNode() as HTMLElement); | ||
|
|
There was a problem hiding this comment.
Please remove this extra new line.
| const formCaptions = querySelectorAllDeep('blr-form-caption', captionWrapper?.getRootNode() as HTMLElement); | ||
|
|
||
| const formCaptionError = querySelectorDeep('.blr-form-caption', formCaptions[1] as HTMLElement); | ||
| const errorIcon = formCaptionError?.getAttribute('errorIcon'); |
There was a problem hiding this comment.
Please adjust this like other test and also adjust the line 51.
thrbnhrtmnn
removed
the
🦹 needs:reviewers (code)
There was a problem hiding this comment.
Hey @RubirajAccenture , I just found one small thing. If I set the Input Field Text component to "hasError"=true, I see a blrInfo icon. This should not be there, the default icon should be undefined. Please also check that the test that you implemented also works and finds this issue.
RubirajAccenture
force-pushed
the
align-hint-and-error-message-icons
branch
2 times, most recently
from
2df90fa to
5c13e91
Compare
RubirajAccenture
force-pushed
the
align-hint-and-error-message-icons
branch
from
5c13e91 to
7908799
Compare
closes #515