Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert tokens to W3C DTCG format #1153

Closed
2 tasks
larserbach opened this issue Sep 3, 2024 · 0 comments · Fixed by #1160
Closed
2 tasks

Convert tokens to W3C DTCG format #1153

larserbach opened this issue Sep 3, 2024 · 0 comments · Fixed by #1160
Assignees
@larserbach
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Milestone
v0.5

Comments

@larserbach
Copy link
Contributor

larserbach commented Sep 3, 2024 •
edited by thrbnhrtmnn
Loading

Our tokens are currently in legacy format since the second draft of the Design Tokens Community Group was released. In order to comply with Style Dictionary v.4.0 we should update our tokens.

Outdated format (our current format):

"some_token": {
  "type": "color",
  "value": "ffff00"
}

New format:

"some_token": {
  "$type": "color",
  "$value": "ffff00"
}

Token Studio offers a convenient way to update our tokens. Our Development pipeline will also need an update then.
More info: https://docs.tokens.studio/convert-to-dtcg-format

ACs

  • Style Dictionary has been updated to v4.0
  • We are using the W3C DTCG format for our tokens
@larserbach larserbach added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers ⭕ core team issue This is for the core team and should not be done by contributors labels Sep 3, 2024
@thrbnhrtmnn thrbnhrtmnn added this to the v0.5 milestone Sep 4, 2024
@larserbach larserbach linked a pull request Sep 25, 2024 that will close this issue
fix(all): #1153 switch to DTCG token format & migrate to latest styledictionary and ts-transform #1160
Merged
larserbach added a commit that referenced this issue Oct 2, 2024
@larserbach
fix(all): #1153 switch to DTCG token format & migrate to latest style…
6f91b28 
…dictionary and ts-transform (#1160)

* using SD v4.00 and latest tokenStudio transforms

* adds function to write themes_generated.cjs

* removes themes.mjs

* dynamically generated theme names and utilize them

* renames theme: light -> light_value

* renames theme: dark -> dark_value

* moves radios.css into radio and radio-group directories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@larserbach larserbach

Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Projects
None yet
Milestone
v0.5
2 participants
@larserbach @thrbnhrtmnn