-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ui-library): change theming approach #991
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianHoffmannS2
changed the title
Feat/740 change theming approach
Feat(ui-library): change theming approach 740
Mar 8, 2024
4 tasks
ChristianHoffmannS2
changed the title
Feat(ui-library): change theming approach 740
Feat(ui-library): change theming approach
Mar 8, 2024
ChristianHoffmannS2
changed the title
Feat(ui-library): change theming approach
fix(ui-library): change theming approach
Mar 8, 2024
ChristianHoffmannS2
force-pushed
the
feat/740-change-theming-approach
branch
9 times, most recently
from
March 14, 2024 12:43
b303b65
to
c13e0aa
Compare
thrbnhrtmnn
previously approved these changes
Mar 14, 2024
ChristianHoffmannS2
force-pushed
the
feat/740-change-theming-approach
branch
from
March 15, 2024 08:49
4b3fbf1
to
e7a7a09
Compare
ChristianHoffmannS2
force-pushed
the
develop
branch
2 times, most recently
from
March 26, 2024 13:22
358f467
to
99c0c93
Compare
faselbaum
force-pushed
the
feat/740-change-theming-approach
branch
from
April 4, 2024 11:44
8f6d433
to
0b03a68
Compare
faselbaum
force-pushed
the
feat/740-change-theming-approach
branch
2 times, most recently
from
April 12, 2024 08:10
70410c1
to
2d4d613
Compare
faselbaum
changed the title
fix(ui-library): change theming approach
refactor(ui-library): change theming approach
Apr 12, 2024
faselbaum
force-pushed
the
feat/740-change-theming-approach
branch
from
April 12, 2024 12:04
333a723
to
fd98290
Compare
This comment was marked as resolved.
This comment was marked as resolved.
faselbaum
added
🦹 needs:reviewers (code)
The issue or pull request needs additional code reviewers
🦹 needs:reviewers (design)
The issue or pull request needs additional design reviewers
labels
Apr 12, 2024
faselbaum
force-pushed
the
feat/740-change-theming-approach
branch
from
April 12, 2024 13:43
fd98290
to
fb60120
Compare
faselbaum
force-pushed
the
feat/740-change-theming-approach
branch
from
April 19, 2024 07:49
4b78cd7
to
bdaef69
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is included
ThemeIterator
)renderThemedCssStrings
functionstyle
class field. See: lit docsWhat is not included
Hints for reviewers
All changes are of similar nature. So it's not necessary to check each file meticulously. Reviewers should focus on finding visual deviations in Storybook when compared to the
develop
branch.Systematic changes for each component:
ComponentThemeIterator
/SemanticThemeIterator
functions.style
class field. See: lit docs. Exceptions are:form-label
s due to missing ShadowRootrange-slider
background gradient generation due to dynamic numerical calculationsIssues found during review (Please add your findings here)
radio-group
layout is brokenCloses #740