fix(ui-library): pressed state removed and updated focus state for readonly #1172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly-for-select-textarea-inputfieldtext-inputfieldnumber
thrbnhrtmnn
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Hey @ashk1996 ,
here are my findings:
#1155 :
- Could we update the input field text, so that the focus ring gets applied as soon as I press down the mouse button? Currently it will only get applied once I release the button (for all other components its working this way already)
- The Input Field hover state when hasError=true looks different than in design (both in dark and light mode) it should look the same as the rest state. Also the focus state is not dominating this state.
#1125 :
- Focusing a readonly Text Area component via a Tab / via keyboard navigation, does not select the value (for input field text and input field number this works).
ashk1996
added
the
🦹 needs:reviewers (design)
thrbnhrtmnn
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
LGTM
@ashk1996 , maybe Christian could also have a quick look on Monday, for me it can be merged :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1155
closes #1125