-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tooltip - separate "floating" component and optimise documentation in code #860
Comments
@veilvokay was working on this before, so there might be something to work with then already when starting this task. It might make sense to check out the tooltipp-refactor-playground branch |
Updated the ACs as discused @angsherpa456 |
As discussed with @faselbaum today, we should change the approach again, sorry for the confusion @angsherpa456 . New idea: We remove the tooltip bubble and only keep the tooltip component. This makes more sense, as this component is way smarter then the tooltip bubble component. The argument, that the tooltip bubble is the equivalent to the tooltip in design is flawed, as most of our components like i.e. the number input have logic, which is not part of the component in design (i.e. clicking the stepper increases or decreases the value). Similar topic for the tooltip, here the logic for the placement of the tooltip is solved in code with the help of the floating ui library, whereas in design this is done by functionality in Figma (i.e. making the component wrapper hugging the referencing element). This new approach would now lead to the following ACs (incl. minor optimisations of the documentation):
|
Description / User story
After the discussion on 31.01. about #303 and #742 we made a few decisions how components should be structured. The goal is to also be aligned between design and code.
Currently the Tooltip is not aligned, as there are two components in code but only one in design. This ticket is to optimise the current situation and to follow the new rules.
One decision could be to completely rename the current Tooltip component in code, as it basically is just a reference to the tooltip and provides the needed logic to place the component for example in a slider.
Requirements
Acceptance Criteria
Additional information
Pseudo Code / Architecture
Code of Conduct
The text was updated successfully, but these errors were encountered: