Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui-library): rename tooltip component (#860) #1076

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

angsherpa456
Copy link
Contributor

closes #860

@angsherpa456 angsherpa456 force-pushed the fix/860_rename-tooltip-component branch 7 times, most recently from cfba182 to d11ed4e Compare April 11, 2024 15:17
Copy link
Contributor

@bar-tay bar-tay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@angsherpa456 angsherpa456 force-pushed the fix/860_rename-tooltip-component branch from d11ed4e to 3bd6ca4 Compare April 17, 2024 15:49
@angsherpa456 angsherpa456 added 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers and removed 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers labels Apr 17, 2024
Copy link
Contributor

@thrbnhrtmnn thrbnhrtmnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in Storybook

@thrbnhrtmnn thrbnhrtmnn removed the 🦹 needs:reviewers (code) The issue or pull request needs additional code reviewers label Apr 17, 2024
@faselbaum faselbaum merged commit c48ce41 into develop Apr 17, 2024
4 of 5 checks passed
@faselbaum faselbaum deleted the fix/860_rename-tooltip-component branch April 17, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip - separate "floating" component and optimise documentation in code
4 participants