Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Field Text, Input Field Number, Select & Text Area - remove margin in error state if no caption is defined #945

Closed
8 tasks done
Tracked by #452
thrbnhrtmnn opened this issue Feb 21, 2024 · 0 comments · Fixed by #1060
Closed
8 tasks done
Tracked by #452
Assignees
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Feb 21, 2024

Description / User story

Currently there is a margin in the error state of the Input Field Text and Text Area, even if no caption is defined. This should not be the case.

Also the default for errorMessageIcon should be undefined for all 3 components.

Requirements / Prerequisites

  • none

Acceptance Criteria

  • Text Area: There is no margin between the Input and the Caption, when no Caption is defined
  • Checkbox: There is no margin between the checkbox and the Caption, when no Caption is defined
  • Select: There is no margin between the Select and the Caption, when no Caption is defined
  • Input Field Text: There is no margin between the Input and the Caption, when no Caption is defined
  • Input Field Number: There is no margin between the Input and the Caption, when no Caption is defined
  • The default of the errorIconMessage is undefined in Text Area, Input Field Text and Input Field Number
  • A test has been implemented to make sure the errorIconMessage does not switch back to defined in the future for all of these 3 components

Additional information

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn thrbnhrtmnn added good first issue Good for newcomers ⌨️ dev issue Task is for developers 💚 contributor issue Good for contributors labels Feb 21, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Text Input, Number Input & Text Area - remove margin in error state if no caption is defined Text Input, Number Input, Select & Text Area - remove margin in error state if no caption is defined Mar 4, 2024
@angsherpa456 angsherpa456 self-assigned this Mar 19, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title Text Input, Number Input, Select & Text Area - remove margin in error state if no caption is defined Input Field Text, Input Field Number, Select & Text Area - remove margin in error state if no caption is defined Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💚 contributor issue Good for contributors ⌨️ dev issue Task is for developers good first issue Good for newcomers
Projects
None yet
2 participants