Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Group - add vertical stacking, fix margin and separate css #589

Open
1 of 7 tasks
Tracked by #452
thrbnhrtmnn opened this issue Nov 14, 2023 · 0 comments
Open
1 of 7 tasks
Tracked by #452
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Nov 14, 2023

Description / User Story

The following differences were found when comparing the RadioGroup in Storybook with the RadioGroup in Design:

  • Behaviour:
    • In code in the initial state no radio is checked, in design there is a checked radio in the disabled and in the readonly state; in the readonly state this leads in the code to a colored control, when focusing the component
    • In readonly state, the checked radio can be changed by focussing another radio (with arrow keys)
  • Layout:
    • Top Padding of FormCaptionGroup is only 8px in code but 16px spacing in design
    • Legend has a 8px top padding in code but no top padding in design
    • Legend has a 8px bottom padding in code but 16px spacing in design
    • Wrapper Element that includes all the radios has no top padding in code but 16px spacing in design
    • Vertical Stacking Variant is missing
    • In error state the margin to the caption is displayed, even if no caption is defined
  • Legend:
    • Legend color is not aligned in default and readonly state (hsl220 vs hsl216)
    • Legend color is black in disabled state in code but grey in design
    • It is not defined in design how the Legend needs to look in dark mode, but if it should be the same as the Radio labels, it is also wrong in the disabled state

Requirements


Acceptance Criteria

  • In disabled state, the legend should consume "Forms.Legend.Disabled"
  • In readOnly state, the legend should consume "Forms.Legend.ReadOnly"
  • Check whats going on with vertical stacking, this layout variant is not available in SB (already implemented appropriate gap tokens)
  • In error state, the whole component does not have a margin to the caption if no caption is defined
  • Separate radio group css and move them to their component folders
  • In case props were changed: Props Excel has been updated / comments have been resolved and props changed from red to black font color > @thrbnhrtmnn or @angelicahoyss can support here

Background information

@thrbnhrtmnn thrbnhrtmnn added 🦹 needs:help Extra attention is needed 🚨 new::bug Something isn't working labels Nov 14, 2023
@thrbnhrtmnn thrbnhrtmnn added 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers and removed 🦹 needs:help Extra attention is needed labels Dec 1, 2023
@thrbnhrtmnn thrbnhrtmnn added the ⭕ core team issue This is for the core team and should not be done by contributors label Jan 5, 2024
@thrbnhrtmnn thrbnhrtmnn added the 🚫 blocked This issue is blocked label Jan 11, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title RadioGroup - fix misalignments/errors RadioGroup - add vertical stacking, fix margin and separate css Jan 11, 2024
@thrbnhrtmnn thrbnhrtmnn changed the title RadioGroup - add vertical stacking, fix margin and separate css Radio Group - add vertical stacking, fix margin and separate css Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚫 blocked This issue is blocked ⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers 🚨 new::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant