Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select & Input Field Text - add new tokens for icon and align design and code #1014

Closed
11 tasks done
thrbnhrtmnn opened this issue Mar 12, 2024 · 5 comments · Fixed by #1036
Closed
11 tasks done

Select & Input Field Text - add new tokens for icon and align design and code #1014

thrbnhrtmnn opened this issue Mar 12, 2024 · 5 comments · Fixed by #1036
Assignees
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Milestone

Comments

@thrbnhrtmnn
Copy link
Contributor

thrbnhrtmnn commented Mar 12, 2024

Description / User story

After discussing #567 in todays design review we decided to move this issue to after release 1.0 and instead focus on aligning design and code for the icons in the select and the input field text components without introducing a new component.

The solution would therefor just use the existing icon component and apply color and size tokens which will be defined by design.

The whole topic will be revisited with #567 in the future (after release 1.0) to identify and research if we need a separate input icon component which might then probably replace the current solution.

This ticket also solves #487 so this ticket has been closed.

Requirements / Prerequisites

  • none

Acceptance Criteria

Select:

  • Design: The icon in the select uses its own color and sizing tokens.
  • Code: The icon in the select uses the defined color and sizing tokens from design.
  • Design: In error state the error icon has been removed. The chevron icon is always visible.
  • Code: In error state the error icon has been removed. The chevron icon is always visible.
  • Design & Code: The icon should be overwriteable

Input Field Text:

  • Design: The error icon inside the input field has been removed
  • Code: The error icon inside the input field has been removed
  • Design: In error state the icon part uses the newly defined color and sizing tokens
  • Code: In error state the icon part uses the defined color and sizing tokens from design
  • Design & Code: The icon should be overwriteable

Additional information

  • ...

Code of Conduct

  • I agree to follow this project's Code of Conduct
@thrbnhrtmnn
Copy link
Contributor Author

Findings from todays review:

  • Design: Input Field Text Type Text still has the error filled icon in design in error state, the component was overlooked maybe
  • Design & Dev: Icons should not be displayed in readonly state as per design, should this really be the case also for the input field text type password? The change will be done now, so Dev part is already done next week, when Design is back and can make a decision

@larserbach
Copy link
Contributor

With this task we also removed read only state from the select component in design (the readonly state was never implemented, and is also not a standard feature of the html select element)

@thrbnhrtmnn
Copy link
Contributor Author

Hey @larserbach , so #476 is not needed anymore and can be closed, right?

@larserbach
Copy link
Contributor

Yes, it's done

@thrbnhrtmnn
Copy link
Contributor Author

thrbnhrtmnn commented Apr 11, 2024

PR is not merged yet :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭕ core team issue This is for the core team and should not be done by contributors 🎨 design issue Task is for designers ⌨️ dev issue Task is for developers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants