Nm dqm egamma v update for13 1 x #41987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lCaHOCalibProducer [13.1.X] use `onlineMetaDataDigis` when available for retrieval of average PU in `AlCaHOCalibProducer`
Apply clang-tidy and clang-format changes [LLVM 14, 13.1.x]
… fix for ZDC simulation geometry
[13.1.X] SiPixel Payload Inspector: improve `SiPixelDynamicInefficiency` parametrization vs PU plotting
Development of HLT menus for `CMSSW_13_0_X`. This update includes the integration of the following JIRA tickets. - [CMSHLT-2695](https://its.cern.ch/jira/browse/CMSHLT-2695): [HIG] new HH4b triggers for `ParkingHH` dataset - [CMSHLT-2697](https://its.cern.ch/jira/browse/CMSHLT-2697): [HIG] retuning of `HLT_Diphoton30_18_R9IdL*` triggers - [CMSHLT-2702](https://its.cern.ch/jira/browse/CMSHLT-2702): [HIG,EXO] new triggers for VBF parking - [CMSHLT-2734](https://its.cern.ch/jira/browse/CMSHLT-2734): [HIG] addition of `HLT_Photon60_*_PFJetsMJJ300DEta3_v` to EGamma PD(s) - [CMSHLT-2743](https://its.cern.ch/jira/browse/CMSHLT-2743): [EXO] displaced-jets triggers for LLP parking - [CMSHLT-2744](https://its.cern.ch/jira/browse/CMSHLT-2744): [EXO] delayed-jets triggers for LLP parking - [CMSHLT-2747](https://its.cern.ch/jira/browse/CMSHLT-2747): [HCAL] increase HB-RecHit thresholds for 2023 data-taking - [CMSHLT-2748](https://its.cern.ch/jira/browse/CMSHLT-2748): [JME,HCAL] replace `L1_SingleJet35*` seeds with `L1_ZeroBias` in triggers of GRun menu - [CMSHLT-2750](https://its.cern.ch/jira/browse/CMSHLT-2750): [HIG] correct bugged instances of `HLTPFJetTag` in MSSM-Hbb triggers - [CMSHLT-2754](https://its.cern.ch/jira/browse/CMSHLT-2754): [EXO] delayed-jet and delayed-photon triggers for "satellite" collisions - [CMSHLT-2756](https://its.cern.ch/jira/browse/CMSHLT-2756): [MUO] update of muon-InsideOut seed-classifier BDT training and wp for 2023 - [CMSHLT-2759](https://its.cern.ch/jira/browse/CMSHLT-2759): [HIG,B2G] PNet trainings for 2023 and update of PNet-WPs in all PNet-based triggers - [CMSHLT-2760](https://its.cern.ch/jira/browse/CMSHLT-2760): [HCAL] removal of `HLT_HcalIsolatedbunch_v` trigger and `IsolatedBunch` dataset - [CMSHLT-2772](https://its.cern.ch/jira/browse/CMSHLT-2772): [HIG] additional control triggers for VBF HToCC search - [CMSHLT-2780](https://its.cern.ch/jira/browse/CMSHLT-2780): [HIG,B2G,TOP] move some HT+Jet+BTag triggers to `ParkingHH` dataset - [CMSHLT-2791](https://its.cern.ch/jira/browse/CMSHLT-2791): [EXO] set PS=0 for `HLT_HT200_L1SingleLLPJet_DisplacedDijet35_Inclusive1PtrkShortSig5_v`
Backport to 13_1_X of cms-sw#41275 Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano
Undo new line modification Remove nan check in pflinker Remove nan check from rescale
do not allow crashes in `isEmpty(int bx)` method of `BXVector` [`13_1_X`]
…BX0Check improve how `HLTPrescaler` checks presence of (Stage-2) L1-uGT results [`13_1_X`]
…e4_isSiFE_Fix [13_1_X] HGCAL: Fix HGCHEB isSiFE configuration
PPS DQM plots for new RPOTs 45-220-NR-HR and 56-220-NR-HR (backport of 41389) [13_1_X]
…_for131X HLT menu development for `13_0_X` (8/N): GRun menu V1.1 of 2023 [`13_1_X`]
…LogError
do not throw exception in `Trigger{Bx,Rates}Monitor` if L1-uGT results are unavailable [`13_1_X`]
[13.1.X] Oracle test: Use fake/random DB name
…_run3_GTs_13_1_X [13_1_X] Update run3 data GTs
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41987/35954
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
It seems your commit (2799bf4) is based on a 13_1_X IB (83835cb, CMSSW_13_1_X_2023-06-14-2300 to be exact) after the 13_1_X and master diverged. Therefore this branch is mergeable only in 13_1_X. In principle you could change the base branch of the PR to |
|
Hello,
thanks for the explanation. I do not plan to issue another PR.
Whenever this PR can be integrated is fine.
Nancy
…On 16.06.23 16:44, Matti Kortelainen wrote:
NOTE: I am not sure what it says that I want to merge 129 commits
... I only committed two files
It seems your commit (2799bf4
<2799bf4>)
is based on a 13_1_X IB (83835cb
<83835cb>,
CMSSW_13_1_X_2023-06-14-2300 to be exact) after the 13_1_X and master
diverged. Therefore this branch is mergeable only in 13_1_X. In
principle you could change the base branch of the PR to
|cms_sw:CMSSW_13_1_X|, in which case you would have to open a separate
PR for the master branch that would be reviewed first (by either
cherry-picking your commit on top of e.g. 13_2_0_pre2 or recent IB, or
rebasing your branch there).
—
Reply to this email directly, view it on GitHub
<#41987 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6G2XFLO26SHFHDF4N2STXLRWMRANCNFSM6AAAAAAZJEKYMY>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
--------------vpBoC0cSw0cV5BKmvw1CsnK8
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Hello,<br>
thanks for the explanation. I do not plan to issue another PR. <br>
Whenever this PR can be integrated is fine. <br>
<br>
Nancy<br>
<br>
<br>
<div class="moz-cite-prefix">On 16.06.23 16:44, Matti Kortelainen
wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
<blockquote>
<p dir="auto">NOTE: I am not sure what it says that I want to
merge 129 commits ... I only committed two files</p>
</blockquote>
<p dir="auto">It seems your commit (<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/cms-sw/cmssw/commit/2799bf49f321b2a9fed334330135523b1a0315d2/hovercard" href="2799bf4" moz-do-not-send="true"><tt>2799bf4</tt></a>) is based on a
13_1_X IB (<a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https://github.com/cms-sw/cmssw/commit/83835cb4e477d5cd464c5fcff310d82e259f093f/hovercard" href="83835cb" moz-do-not-send="true"><tt>83835cb</tt></a>,
CMSSW_13_1_X_2023-06-14-2300 to be exact) after the 13_1_X and
master diverged. Therefore this branch is mergeable only in
13_1_X. In principle you could change the base branch of the PR
to <code class="notranslate">cms_sw:CMSSW_13_1_X</code>, in
which case you would have to open a separate PR for the master
branch that would be reviewed first (by either cherry-picking
your commit on top of e.g. 13_2_0_pre2 or recent IB, or rebasing
your branch there).</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#41987 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6G2XFLO26SHFHDF4N2STXLRWMRANCNFSM6AAAAAAZJEKYMY" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you authored the thread.<img src="https://github.com/notifications/beacon/ABC6G2VMPX6SVZCDSOTLM23XLRWMRA5CNFSM6AAAAAAZJEKYM2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS7B3TLI.gif" alt="" moz-do-not-send="true" width="1" height="1"><span style="color: transparent; font-size: 0; display: none;
visibility: hidden; overflow: hidden; opacity: 0; width: 0;
height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><cms-sw/cmssw/pull/41987/c1594812084</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#41987 (comment)",
"url": "#41987 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940</pre>
</body>
</html>
--------------vpBoC0cSw0cV5BKmvw1CsnK8--
|
Ok, then you'd need to cherry-pick or rebase your commit on top of 13_2_X (e.g. pre2). You can either update this PR by using the same branch name and force-pushing, or close this PR and open a new one with your updated branch. |
|
Sorry Matti,
almost certainly there is a misunderstanding somewhere.
In your previous message you said
"Therefore this branch is mergeable only in 13_1_X"
which would be fine with me. But then the question comes about when the
next X would come.
Thanks,
Nancy
…On 16.06.23 17:08, Matti Kortelainen wrote:
thanks for the explanation. I do not plan to issue another PR.
Whenever this PR can be integrated is fine.
Ok, then you'd need to cherry-pick or rebase your commit on top of
13_2_X (e.g. pre2). You can either update this PR by using the same
branch name and force-pushing, or close this PR and open a new one
with your updated branch.
—
Reply to this email directly, view it on GitHub
<#41987 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6G2TIMFXT5FSU6WLPXW3XLRZHVANCNFSM6AAAAAAZJEKYMY>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
--------------EC0ngcq1YvCYcWboRVAIwcOh
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Sorry Matti,<br>
almost certainly there is a misunderstanding somewhere. <br>
In your previous message you said <br>
"Therefore this branch is mergeable only in 13_1_X"<br>
which would be fine with me. But then the question comes about when
the next X would come. <br>
<br>
Thanks,<br>
Nancy <br>
<br>
<br>
<br>
<div class="moz-cite-prefix">On 16.06.23 17:08, Matti Kortelainen
wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
<blockquote>
<p dir="auto">thanks for the explanation. I do not plan to issue
another PR. Whenever this PR can be integrated is fine.</p>
</blockquote>
<p dir="auto">Ok, then you'd need to cherry-pick or rebase your
commit on top of 13_2_X (e.g. pre2). You can either update this
PR by using the same branch name and force-pushing, or close
this PR and open a new one with your updated branch.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#41987 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6G2TIMFXT5FSU6WLPXW3XLRZHVANCNFSM6AAAAAAZJEKYMY" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you authored the thread.<img src="https://github.com/notifications/beacon/ABC6G2RV6IZB3JH7DNEXZX3XLRZHVA5CNFSM6AAAAAAZJEKYM2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS7B5XPA.gif" alt="" moz-do-not-send="true" width="1" height="1"><span style="color: transparent; font-size: 0; display: none;
visibility: hidden; overflow: hidden; opacity: 0; width: 0;
height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><cms-sw/cmssw/pull/41987/c1594846960</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#41987 (comment)",
"url": "#41987 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940</pre>
</body>
</html>
--------------EC0ngcq1YvCYcWboRVAIwcOh--
|
|
Our policy is to review, test, and merge everything first in the master branch (i.e. 13_2_X release cycle currently), and only then consider backport PRs to earlier release cycles. |
|
Ok ! Understood. I will then issue a new PR for 13_2_X and remove ( if I
manage :-)) this one.
Thanks Matti
…On 16.06.23 17:37, Matti Kortelainen wrote:
Our policy is to review, test, and merge everything first in the
master branch (i.e. 13_2_X release cycle currently), and only then
consider backport PRs to earlier release cycles.
—
Reply to this email directly, view it on GitHub
<#41987 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABC6G2SAI6CUPB3XDTD5J6LXLR4TLANCNFSM6AAAAAAZJEKYMY>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940
--------------nGcnf7rpX0tlnnpZgTO8oZ6W
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit
<html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
Ok ! Understood. I will then issue a new PR for 13_2_X and remove (
if I manage :-)) this one.<br>
Thanks Matti<br>
<br>
<br>
<div class="moz-cite-prefix">On 16.06.23 17:37, Matti Kortelainen
wrote:<br>
</div>
<blockquote type="cite" ***@***.***">
<p dir="auto">Our policy is to review, test, and merge everything
first in the master branch (i.e. 13_2_X release cycle
currently), and only then consider backport PRs to earlier
release cycles.</p>
<p style="font-size:small;-webkit-text-size-adjust:none;color:#666;">—<br>
Reply to this email directly, <a href="#41987 (comment)" moz-do-not-send="true">view it on GitHub</a>, or <a href="https://github.com/notifications/unsubscribe-auth/ABC6G2SAI6CUPB3XDTD5J6LXLR4TLANCNFSM6AAAAAAZJEKYMY" moz-do-not-send="true">unsubscribe</a>.<br>
You are receiving this because you authored the thread.<img src="https://github.com/notifications/beacon/ABC6G2WVYWLMGUMXYFBYHF3XLR4TLA5CNFSM6AAAAAAZJEKYM2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTS7B77Y6.gif" alt="" moz-do-not-send="true" width="1" height="1"><span style="color: transparent; font-size: 0; display: none;
visibility: hidden; overflow: hidden; opacity: 0; width: 0;
height: 0; max-width: 0; max-height: 0; mso-hide: all">Message
ID: <span><cms-sw/cmssw/pull/41987/c1594883983</span><span>@</span><span>github</span><span>.</span><span>com></span></span></p>
<script type="application/ld+json">[
{
***@***.***": "http://schema.org",
***@***.***": "EmailMessage",
"potentialAction": {
***@***.***": "ViewAction",
"target": "#41987 (comment)",
"url": "#41987 (comment)",
"name": "View Pull Request"
},
"description": "View this Pull Request on GitHub",
"publisher": {
***@***.***": "Organization",
"name": "GitHub",
"url": "https://github.com"
}
}
]</script>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Nancy Marinelli
Research Professor
University of Notre Dame, IN, US
CERN, Bdg 40/3-A01, 1211 Geneva
SWITZERLAND
Phone +41-22-76-70809
fax +41-22-76-78940</pre>
</body>
</html>
--------------nGcnf7rpX0tlnnpZgTO8oZ6W--
|
This was referenced Jun 16, 2023
This was referenced Jun 22, 2023
Merged
|
please close Based on #41987 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Minor update in Validation/RecoEgamma/plugins/PhotonValidator.cc, .h. The plot in EB of dR between PF photon candidate and PF neutral hadron candidates is now split
in two |eta| regions (<1 and >1) mainly needed for Phase2, where |eta| >1 receives contributions from the HGCAL reco
PR validation:
Test was made locally using the cmsDriver for PhaseI and PhaseII on the HggGluonfusion sample. All works fine
NOTE: I am not sure what it says that I want to merge 129 commits ... I only committed two files