Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HI mixing wfs for 2023 MC #41971

Merged
merged 1 commit into from
Jun 20, 2023
Merged

Conversation

mandrenguyen
Copy link
Contributor

PR description:

Back in #41095 I introduced MC RelVal workflows for heavy ions with 2023 conditions (previously we had 2022). However, I only add noPU workflows as I was waiting for GEN-SIM input for the mixing workflows.
Now that exists, so this PR adds the mixing ones.
Turns out there was a typo in a parameter in the gen fragments which I fixed as well.

PR validation:

Tested with new wfs 320, 321, 322

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport needed.
Would be cool to squeeze this in 13_2_0_pre2 though, if still possible.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41971/35934

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

  • Configuration/Generator (generators)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@SiewYan, @mkirsano, @bbilin, @alberto-sanchez, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @menglu21, @sunilUIET, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

please test workflow 320, 321, 322

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3bb05/33180/summary.html
COMMIT: f9ec7fa
CMSSW: CMSSW_13_2_X_2023-06-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41971/33180/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3196062
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3196037
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

+1

@srimanob
Copy link
Contributor

Hi @mandrenguyen @menglu21
Just to confirm as the config of GEN is also changed. Does this need to port back to 13_0 as the plan is to use that series for the GEN-SIM. Thx.

@srimanob
Copy link
Contributor

+Upgrade

@mandrenguyen
Copy link
Contributor Author

@srimanob Good point, I'll backport after this is merged.

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants