-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HI mixing wfs for 2023 MC #41971
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41971/35934
|
A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master. It involves the following packages:
@SiewYan, @mkirsano, @bbilin, @alberto-sanchez, @Saptaparna, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @menglu21, @sunilUIET, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test workflow 320, 321, 322 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b3bb05/33180/summary.html Comparison SummarySummary:
|
+1 |
Hi @mandrenguyen @menglu21 |
+Upgrade |
@srimanob Good point, I'll backport after this is merged. |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Back in #41095 I introduced MC RelVal workflows for heavy ions with 2023 conditions (previously we had 2022). However, I only add noPU workflows as I was waiting for GEN-SIM input for the mixing workflows.
Now that exists, so this PR adds the mixing ones.
Turns out there was a typo in a parameter in the gen fragments which I fixed as well.
PR validation:
Tested with new wfs 320, 321, 322
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
No backport needed.
Would be cool to squeeze this in 13_2_0_pre2 though, if still possible.