Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

70 x fix for156 #666

Closed
wants to merge 29 commits into from
Closed

70 x fix for156 #666

wants to merge 29 commits into from

Conversation

vadler
Copy link

@vadler vadler commented Aug 29, 2013

Old #156 plus fix in PFBRECO.

@vadler
Copy link
Author

vadler commented Aug 29, 2013

+1
...finally.

@ktf
Copy link
Contributor

ktf commented Aug 30, 2013

@nclopezo can you please test?

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vadler (Volker Adler) for CMSSW_7_0_X.

70 x fix for156

It involves the following packages:

Validation/RecoEgamma
RecoEgamma/EgammaElectronProducers
DataFormats/EgammaCandidates
CommonTools/ParticleFlow
RecoEgamma/EgammaElectronAlgos
RecoParticleFlow/PFProducer

@thspeer, @rovere, @deguio, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@nclopezo
Copy link
Contributor

Hi,

I took these changes on top of CMSSW_7_0_X_2013-08-30-020, all tests passed.

You can see the logs here:

https://cmssdt.cern.ch/jenkins/job/Pull-Request-Integration/ARCHITECTURE=slc5_amd64_gcc472/322/consoleFull

and the artifacts here:

https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/322/

@nclopezo
Copy link
Contributor

nclopezo commented Sep 2, 2013

Superseded by #680

@nclopezo nclopezo closed this Sep 2, 2013
@slava77
Copy link
Contributor

slava77 commented Sep 11, 2013

Just for the record, I tested this pull request alone in CMSSW_7_0_X_2013-09-10-0200
as a pre-requisite check of #680.
The only visible changes are in the DQM plots of the pfPhotonValidator in the gamma-35 sample. This change is expected due to changes in the associator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants