-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not allow crashes in isEmpty(int bx)
method of BXVector
[13_1_X
]
#41573
do not allow crashes in isEmpty(int bx)
method of BXVector
[13_1_X
]
#41573
Conversation
A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_1_X. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Failed Tests: Build BuildI found compilation error when building: >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTower.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTriggerCell.cc >> Compiling /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTriggerSums.cc /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc: In member function 'const l1t::HGCalTowerMap& l1t::HGCalTowerMap::operator+=(const l1t::HGCalTowerMap&)': /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-05-06-1100/src/DataFormats/L1THGCal/src/HGCalTowerMap.cc:18:12: error: 'endl' was not declared in this scope; did you mean 'std::endl'? 18 | << endl; | ^~~~ | std::endl In file included from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/istream:39, from /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02783/el8_amd64_gcc11/external/gcc/11.2.1-f9b9dfdd886f71cd63f5538223d8f161/include/c++/11.2.1/sstream:38, |
50be075
to
9e83cfc
Compare
Pull request #41573 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2e3568/32445/summary.html Comparison SummarySummary:
|
+l1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
backport of #41572
PR description:
From the description of #41572:
PR validation:
None beyond the checks done for #41572.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
#41572
Fix to public method used by several plugins in CMSSW.