-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timestamp dates in human readable form in the BeamSpot DisplayParameters
template class
#42068
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42068/36048
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Thanks a lot for this Marco! |
nothing. We don't do the diff of the "second column" anyway: https://cern.ch/go/978l |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test testBeamSpotPayloadInspector had ERRORS Comparison SummarySummary:
|
…meters template class
eacba5a
to
4ebc9bf
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42068/36053
|
Pull request #42068 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again. |
please test |
DisplayParameters
template classDisplayParameters
template class
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe16fd/33366/summary.html Comparison SummarySummary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Simple addition of human readable timestamps (in UTC) for some of the
BeamSpotOnline
parameters in the dedicated paylaod inspector class.PR validation:
Run the following command:
and obtained the following plot:
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Not a backport, not to be backported