add timestamp dates in human readable form in the BeamSpot DisplayParameters template class

[mmusich]

PR description:

Simple addition of human readable timestamps (in UTC) for some of the BeamSpotOnline parameters in the dedicated paylaod inspector class.

PR validation:

Run the following command:

getPayloadData.py \
     --plugin pluginBeamSpotOnline_PayloadInspector \
     --plot plot_BeamSpotOnlineParameters \
     --tag BSonline_TS1_2023_bootstrap_v1 \
     --input_params '{}' \
     --time_type Lumi \
     --iovs '{"start_iov": "4294967297", "end_iov": "4294967297"}' \
     --db Prep \
     --test ;

and obtained the following plot:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, not to be backported

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42068/36048

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/BeamSpotPlugins/interface/BeamSpotPayloadInspectorHelper.h modified in PR(s): Nm dqm egamma v update for13 1 x #41987

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondCore/BeamSpotPlugins (db)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[francescobrivio]

Thanks a lot for this Marco!
Just a (probably stupid) question: what happens for the "diff" plots (e.g. IOV vs IOV or tag vs tag)?

[mmusich]

Just a (probably stupid) question: what happens for the "diff" plots (e.g. IOV vs IOV or tag vs tag)?

nothing. We don't do the diff of the "second column" anyway: https://cern.ch/go/978l

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe16fd/33357/summary.html
COMMIT: eacba5a
CMSSW: CMSSW_13_2_X_2023-06-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42068/33357/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testBeamSpotPayloadInspector had ERRORS

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 9 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200239
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42068/36053

• This PR adds an extra 16KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/BeamSpotPlugins/interface/BeamSpotPayloadInspectorHelper.h modified in PR(s): Nm dqm egamma v update for13 1 x #41987

[cmsbuild]

Pull request #42068 was updated. @cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

[mmusich]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fe16fd/33366/summary.html
COMMIT: 4ebc9bf
CMSSW: CMSSW_13_2_X_2023-06-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42068/33366/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3200270
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3200242
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+1

• PR according to description
• tests are clean

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1