Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex160Z Remove overlaps in the ZDC part and apply the correction to all Run3 scenarios #41464

Merged
merged 1 commit into from
May 9, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Remove overlaps in the ZDC part and apply the correction to all Run3 scenarios

PR validation:

Use the overlap check tool in SimG4Core/PrintGeomInfo

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Should one make a new geometry payload for 2021 and 2023?

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

@civanch Should one make payloads for 2021/2023 geometries?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41464/35328

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/ForwardCommonData (geometry)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771a66/32247/summary.html
COMMIT: 56c9a4e
CMSSW: CMSSW_13_1_X_2023-04-28-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41464/32247/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460852
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Apr 29, 2023

+1

@civanch
Copy link
Contributor

civanch commented Apr 29, 2023

@bsunanda , all, I think this should be backported to 13_0_X. I am not sure about 12_4_X.

@smuzaffar smuzaffar modified the milestones: CMSSW_13_1_X, CMSSW_13_2_X May 4, 2023
@srimanob
Copy link
Contributor

srimanob commented May 5, 2023

@cmsbuild please test

Re-trigger the test after a week.

@perrotta
Copy link
Contributor

perrotta commented May 5, 2023

@bsunanda perhaps a backport to 13_1_X could be in order, just in case that release will be used for some reprocessing of this year data later in summer

@srimanob
Copy link
Contributor

srimanob commented May 5, 2023

Does this PR effect only simulation geometry, or also reconstruction geometry?

@srimanob
Copy link
Contributor

srimanob commented May 6, 2023

Hi @bsunanda @perrotta

Maybe hold 13_0 for now (both coding and mc)? As if partial re-reco will be done, it will still be used with old MC. The update will make inconsistent between data and MC geometry.

@bsunanda
Copy link
Contributor Author

bsunanda commented May 6, 2023 via email

@srimanob
Copy link
Contributor

srimanob commented May 6, 2023

My comment based on your answer on reco geometry. If you update the gt and change also reco geometry, then it will not match on ppd plan to keep current mc with partial rereco.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2023

-1

Failed Tests: AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771a66/32431/summary.html
COMMIT: 56c9a4e
CMSSW: CMSSW_13_2_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41464/32431/install.sh to create a dev area with all the needed externals and cmssw changes.

AddOn Tests

[fastsim1:1] cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast  -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,VALIDATION  --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - elapsed time: 265 sec (ended on Sat May  6 16:40:19 2023) - exit: 35584

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460836
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460811
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

bsunanda commented May 7, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-771a66/32448/summary.html
COMMIT: 56c9a4e
CMSSW: CMSSW_13_2_X_2023-05-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41464/32448/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460836
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460811
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented May 8, 2023

+Upgrade

I assume no change can be seen in the PR test, so big samples should be validated, i.e. relvals.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 305818d into cms-sw:master May 9, 2023
cmsbuild added a commit that referenced this pull request May 21, 2023
Run3-gex160Y Backport of #41464 to CMSSW version 13_1_X which contains a bug fix for ZDC simulation geometry
cmsbuild added a commit that referenced this pull request May 21, 2023
Run3-gex160XZ Backport the corrections to the ZDC geometry for Run3 (#41464) and Phase2 (#41480) to CMSSW version 13_0_X
jsamudio pushed a commit to jsamudio/cmssw that referenced this pull request Jun 25, 2023
Ming-Yan pushed a commit to Ming-Yan/cmssw that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants