[CLANG] remove unused variables

[smuzaffar]

#41528 clean also introduced a unused variable warning, this PR fixes it

[smuzaffar]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41603/35496

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DQMOffline/JetMET (dqm)

@pmandrik, @emanueleusai, @micsucmed, @syuvivida, @rvenditti can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-659d20/32517/summary.html
COMMIT: db2f757
CMSSW: CMSSW_13_2_X_2023-05-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41603/32517/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar [DQM-RECONSTRUCTION] [LLVM16]Fix set but unused variables warnings #41507
• @aandvalenzuela [L1] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41595
• @aandvalenzuela [SIMULATION-UPGRADE] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41582
• @smuzaffar [DQM] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41528
• @missirol improve how HLTPrescaler checks presence of (Stage-2) L1-uGT results #41575
• @smuzaffar [DB-DQM] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41521
• @aandvalenzuela [DQM-GENERATORS] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41585
• @trackreco Introduce procModifier for parabolic magnetic field in track building for default iterative tracking #41557
• @bsunanda Run3-gex160Z Remove overlaps in the ZDC part and apply the correction to all Run3 scenarios #41464
• @smuzaffar [DQM] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41537
• @smuzaffar [GENERATORS] [CLANG] Fix warnings reported by llvm16 in CLANG IBs #41535

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-659d20/32517/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-659d20/32517/git-merge-result

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460836
• DQMHistoTests: Total failures: 9
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460805
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[smuzaffar]

@rappoccio , can we get this in for next IB? This should fix the compilation warnings we see in 13.2.X

[smuzaffar]

sorry, I am merging it for the IB