[DB-DQM] [CLANG] Fix warnings reported by llvm16 in CLANG IBs

[smuzaffar]

Fixed set but unused warnings from clang-16 in CLANG IBs

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41521/35393

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)

@pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @rvenditti, @micsucmed, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@cmsbuild please test

• even though the "FakeBeamMonitor" is currently not used anywhere

[tvami]

@cmsbuild , please test for CMSSW_13_1_CLANG_X

• we should test it for CLANG IB too

[smuzaffar]

@cmsbuild , please test for CMSSW_13_1_CLANG_X

* we should test it for CLANG IB too

though there is no need to test against clang IB but if you really want then please wait for 13.2.CLANG.X IB (tonight after 23h00)

[tvami]

@cmsbuild , please test for CMSSW_13_2_CLANG_X

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8eb579/32371/summary.html
COMMIT: c70506c
CMSSW: CMSSW_13_1_X_2023-05-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41521/32371/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 7 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460849
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[tvami]

+db

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1