-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve how HLTPrescaler
checks presence of (Stage-2) L1-uGT results
#41575
improve how HLTPrescaler
checks presence of (Stage-2) L1-uGT results
#41575
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41575/35444
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0ed72e/32449/summary.html Comparison SummarySummary:
|
+hlt |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR improves how the
HLTPrescaler
checks for the availability of the Stage-2 L1-uGT results of BX=0 before accessing them to find the index of the prescale column.This check is currently done by first calling
BXVector::begin(0)
, but the latter call can in principle result in a runtime error if the content of theBXVector
is empty, see here.The check is updated using
BXVector::isEmpty(0)
, which shouldn't lead to runtime crashes under any circumstances provided #41572 and its backports are integrated.Merely technical. No changes expected.
PR validation:
None.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
CMSSW_13_1_X
CMSSW_13_0_X