[DQM] [CLANG] Fix warnings reported by llvm16 in CLANG IBs

[smuzaffar]

Fixed set but unused warnings from clang-16 in CLANG IBs

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41528/35400

• This PR adds an extra 456KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File DQM/TrackingMonitor/src/TrackAnalyzer.cc modified in PR(s): "SCALLumi" histos renamed as "OnlineLumi" #41220

[cmsbuild]

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

• DPGAnalysis/HcalTools (dqm)
• DQM/CSCMonitorModule (dqm)
• DQM/DTMonitorClient (dqm)
• DQM/EcalCommon (dqm)
• DQM/HcalTasks (dqm)
• DQM/L1TMonitor (dqm)
• DQM/L1TMonitorClient (dqm)
• DQM/Physics (dqm)
• DQM/RPCMonitorDigi (dqm)
• DQM/SiPixelMonitorClient (dqm)
• DQM/SiPixelMonitorTrack (dqm)
• DQM/SiStripCommissioningAnalysis (dqm)
• DQM/SiStripCommissioningClients (dqm)
• DQM/TrackerRemapper (dqm)
• DQM/TrackingMonitor (dqm)
• DQM/TrackingMonitorClient (dqm)
• DQMOffline/CalibCalo (dqm)
• DQMOffline/EGamma (dqm)
• DQMOffline/Hcal (dqm)
• DQMOffline/JetMET (dqm)
• DQMOffline/Muon (dqm)
• DQMOffline/Trigger (dqm)
• DQMServices/Components (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@erikbutz, @rappoccio, @VourMa, @schoef, @missirol, @argiro, @bsunanda, @fioriNTU, @thomreis, @threus, @seemasharmafnal, @acimmino, @mmarionncern, @hdelanno, @battibass, @ahinzmann, @abdoulline, @JanFSchulte, @jhgoh, @jdolen, @HuguesBrun, @cericeci, @ptcox, @trocino, @rociovilar, @abbiendi, @barvic, @DryRun, @sroychow, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @jandrea, @idebruyn, @mmusich, @mtosi, @arossi83, @rchatter, @Fedespring, @calderona, @wang0jin, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[perrotta]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9bd45e/32397/summary.html
COMMIT: c097a56
CMSSW: CMSSW_13_1_X_2023-05-04-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41528/32397/install.sh to create a dev area with all the needed externals and cmssw changes.

Found compilation warnings

Comparison Summary

Summary:

• You potentially removed 8 lines from the logs
• Reco comparison results: 10 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3460877
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3460849
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1