Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex160Z Remove overlaps in the Phase2 scenarios which used to be caused by an error in zdc.xml #41480

Merged
merged 1 commit into from
May 3, 2023

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented May 1, 2023

PR description:

Remove overlaps in the Phase2 scenarios which used to be caused by an error in zdc.xml

PR validation:

Tested using scripts in SimG4Core/PrintGeomInfo/test/python

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41480/35343

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 1, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/ForwardCommonData (geometry)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented May 2, 2023

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e49462/32284/summary.html
COMMIT: 43567c6
CMSSW: CMSSW_13_1_X_2023-05-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41480/32284/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460849
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented May 2, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented May 3, 2023

@AdrianoDee @srimanob if you sign this in the next 5' we can still include this fix in 13_1_X

@AdrianoDee
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 3, 2023

+1

@cmsbuild cmsbuild merged commit 21ff8f0 into cms-sw:master May 3, 2023
bsunanda pushed a commit to bsunanda/cmssw that referenced this pull request May 5, 2023
cmsbuild added a commit that referenced this pull request May 21, 2023
Run3-gex160XZ Backport the corrections to the ZDC geometry for Run3 (#41464) and Phase2 (#41480) to CMSSW version 13_0_X
jsamudio pushed a commit to jsamudio/cmssw that referenced this pull request Jun 25, 2023
Ming-Yan pushed a commit to Ming-Yan/cmssw that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants