Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.1.X] SiPixel Payload Inspector: improve SiPixelDynamicInefficiency parametrization vs PU plotting #41555

Merged
merged 4 commits into from
May 5, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 5, 2023

backport of #41515

PR description:

The goal of this PR is to introduce the possibility to display two curves of the pixel dynamic inefficiency parametrization vs inst. luminosity at the same time from the payload inspector service. Some graphical improvement for the display of the single payload viewer (introduced originally in #40856) is also introduced.
The introduced class is also tested in the unit tests of this package.

PR validation:

Run:

getPayloadData.py \
    --plugin pluginSiPixelDynamicInefficiency_PayloadInspector \
    --plot plot_SiPixelDynamicInefficiencyPUParamComparisonTwoTags \
    --tag SiPixelDynamicInefficiency_phase1_2023_v2_fix3  \
    --tagtwo SiPixelDynamicInefficiency_phase1_2023_v2_fix2  \
    --time_type Run \
    --iovs '{"start_iov": "1", "end_iov": "1"}' \
    --iovstwo '{"start_iov": "1", "end_iov": "1"}' \
    --db Prod \
    --test;

and obtained the following plot:

image

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

verbatim backport of #41515, just because CMSSW_13_1_0might appear faster than theCMSSW_13_2_0_pre1`, in order to give this to fruition to users.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_13_1_X.

It involves the following packages:

  • CondCore/SiPixelPlugins (db)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@VinInn, @mroguljic, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented May 5, 2023

please test

@tvami
Copy link
Contributor

tvami commented May 5, 2023

+1
Screen Shot 2023-05-05 at 07 58 44

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b2918/32416/summary.html
COMMIT: f9bc1b8
CMSSW: CMSSW_13_1_X_2023-05-05-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41555/32416/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460877
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460849
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9056c64 into cms-sw:CMSSW_13_1_X May 5, 2023
@mmusich mmusich deleted the improve_dyn_ineff_PI branch May 5, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants