Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug-fix] Add NANOAOD output to RECONANORUN3 step #42047

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

srimanob
Copy link
Contributor

PR description:

This is a bug fix PR as Nano output is missing from RECONANORUN3 step (both 2022 and 2023).
Thanks for @VinInn to spot this.

PR validation:

Try with workflow 140.065

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

To be discussed if backport is needed or not.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42047/36027

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

@cmsbuild please test workflow 140.065

@mmusich
Copy link
Contributor

mmusich commented Jun 22, 2023

@srimanob what about merging first #42031 and then customizing also the ZB specialized ones?

@srimanob
Copy link
Contributor Author

@srimanob what about merging first #42031 and then customizing also the ZB specialized ones?

Sure, I just sign it. I will adapt this PR later.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa8e08/33331/summary.html
COMMIT: 85149b1
CMSSW: CMSSW_13_2_X_2023-06-21-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42047/33331/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 12 lines from the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3251788
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251757
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

type bug-fix

@srimanob
Copy link
Contributor Author

test parameters:

  • workflows = 140.065,141.008

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-42047/36058

@cmsbuild
Copy link
Contributor

Pull request #42047 was updated. @cmsbuild, @bbilin, @srimanob, @sunilUIET, @AdrianoDee can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@srimanob srimanob changed the title Add NANOAOD output to RECONANORUN3 step [Bug-fix] Add NANOAOD output to RECONANORUN3 step Jun 24, 2023
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fa8e08/33373/summary.html
COMMIT: 682b8e8
CMSSW: CMSSW_13_2_X_2023-06-24-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42047/33373/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 9 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3340707
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3340679
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 215 log files, 165 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

+Upgrade

NANOAOD is produced in Run-3 data workflow with the PR.

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants